Log additional details when ignoring first hops #2771
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2771 +/- ##
========================================
Coverage 88.59% 88.59%
========================================
Files 115 115
Lines 90254 90456 +202
Branches 90254 90456 +202
========================================
+ Hits 79965 80144 +179
- Misses 7879 7903 +24
+ Partials 2410 2409 -1 ☔ View full report in Codecov by Sentry. |
wpaulino
reviewed
Dec 4, 2023
Users are often confused when we fail to find a route due to some requirements on the first hop are not being met. While we now take note and log such candidates, we still previously required users to check additional details to figure out why exactly the router refused to route over a particular first hop. Here, we add additional TRACE logging, in particular for `ChannelDetails::next_outbound_htlc_limit_msat` and `ChannelDetails::next_outbound_htlc_minimum_msat` when they are relevant.
tnull
force-pushed
the
2023-12-log-details-for-ignored-first-hop
branch
from
dab7f6f to
52ecce9
Compare
wpaulino
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users are often confused when we fail to find a route due to some requirements on the first hop are not being met. While we now take note and log such candidates, we still previously required users to check additional details to figure out why exactly the router refused to route over a particular first hop.
Here, we add additional details to our TRACE logging, in particular for
ChannelDetails::next_outbound_htlc_limit_msatandChannelDetails::next_outbound_htlc_minimum_msat, when they are relevant.