Skip to content

Update full_stack_target to take an arbitrary config object #2810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 5, 2024
Merged

Update full_stack_target to take an arbitrary config object #2810

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c725842
Disable fuzzing-reachable debug assertion
TheBlueMatt Dec 24, 2023
248e2f5
Disable fuzzing-reachable debug assertions in `ChannelMonitor`s
TheBlueMatt Dec 25, 2023
f62a96e
Use arbitrary config object in full_stack_target fuzzer
TheBlueMatt Dec 23, 2023
76ed917
Update fuzz CI job to use our MSRV rather than 1.58
TheBlueMatt Jan 18, 2024
3e0d55b
Use utility methods to construct `HashMap`s and `HashSet`s
TheBlueMatt Jan 1, 2024
efbaa41
Stop relying on `Hash{Set,Map}::from_iter` directly
TheBlueMatt Jan 18, 2024
dedc830
Bump `hashbrown` dependency to 0.13
TheBlueMatt Jan 18, 2024
c9e4410
Fix test variable typos
TheBlueMatt Jan 11, 2024
7377cc9
[fuzz] Fix slice copy in `peer_crypt_target`
TheBlueMatt Jan 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions lightning/src/ln/functional_tests.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5402,11 +5402,11 @@ fn do_test_fail_backwards_unrevoked_remote_announce(deliver_last_raa: bool, anno

let as_events = nodes[0].node.get_and_clear_pending_events();
assert_eq!(as_events.len(), if announce_latest { 10 } else { 6 });
let mut as_failds = new_hash_set();
let mut as_faileds = new_hash_set();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you're already doing a typo fix, might as well call them a_failures or, better yet (imo), failures_a.

let mut as_updates = 0;
for event in as_events.iter() {
if let &Event::PaymentPathFailed { ref payment_hash, ref payment_failed_permanently, ref failure, .. } = event {
assert!(as_failds.insert(*payment_hash));
assert!(as_faileds.insert(*payment_hash));
if *payment_hash != payment_hash_2 {
assert_eq!(*payment_failed_permanently, deliver_last_raa);
} else {
Expand All @@ -5418,21 +5418,21 @@ fn do_test_fail_backwards_unrevoked_remote_announce(deliver_last_raa: bool, anno
} else if let &Event::PaymentFailed { .. } = event {
} else { panic!("Unexpected event"); }
}
assert!(as_failds.contains(&payment_hash_1));
assert!(as_failds.contains(&payment_hash_2));
assert!(as_faileds.contains(&payment_hash_1));
assert!(as_faileds.contains(&payment_hash_2));
if announce_latest {
assert!(as_failds.contains(&payment_hash_3));
assert!(as_failds.contains(&payment_hash_5));
assert!(as_faileds.contains(&payment_hash_3));
assert!(as_faileds.contains(&payment_hash_5));
}
assert!(as_failds.contains(&payment_hash_6));
assert!(as_faileds.contains(&payment_hash_6));

let bs_events = nodes[1].node.get_and_clear_pending_events();
assert_eq!(bs_events.len(), if announce_latest { 8 } else { 6 });
let mut bs_failds = new_hash_set();
let mut bs_faileds = new_hash_set();
let mut bs_updates = 0;
for event in bs_events.iter() {
if let &Event::PaymentPathFailed { ref payment_hash, ref payment_failed_permanently, ref failure, .. } = event {
assert!(bs_failds.insert(*payment_hash));
assert!(bs_faileds.insert(*payment_hash));
if *payment_hash != payment_hash_1 && *payment_hash != payment_hash_5 {
assert_eq!(*payment_failed_permanently, deliver_last_raa);
} else {
Expand All @@ -5444,12 +5444,12 @@ fn do_test_fail_backwards_unrevoked_remote_announce(deliver_last_raa: bool, anno
} else if let &Event::PaymentFailed { .. } = event {
} else { panic!("Unexpected event"); }
}
assert!(bs_failds.contains(&payment_hash_1));
assert!(bs_failds.contains(&payment_hash_2));
assert!(bs_faileds.contains(&payment_hash_1));
assert!(bs_faileds.contains(&payment_hash_2));
if announce_latest {
assert!(bs_failds.contains(&payment_hash_4));
assert!(bs_faileds.contains(&payment_hash_4));
}
assert!(bs_failds.contains(&payment_hash_5));
assert!(bs_faileds.contains(&payment_hash_5));

// For each HTLC which was not failed-back by normal process (ie deliver_last_raa), we should
// get a NetworkUpdate. A should have gotten 4 HTLCs which were failed-back due to
Expand Down