Add further standard derives to various onion message structs

[TheBlueMatt]

No description provided.

[coderabbitai]

Walkthrough

The modifications in the codebase primarily focus on enhancing the enums within the messenger.rs file by implementing additional traits. Specifically, the Hash trait has been added to the Destination, SendSuccess, and SendError enums, enabling hash-based operations. Moreover, the Debug trait is now implemented for the PeeledOnion enum, facilitating easier debugging by providing a format for printing values in a human-readable form.

Changes

File Path	Change Summary
.../onion_message/messenger.rs	Added Hash trait to Destination, SendSuccess, SendError enums; Added Debug trait to PeeledOnion enum

🐇✨
In the realm of code, where changes abound,
A rabbit hopped, leaving traits on the ground.
Hash and Debug, in enums they did weave,
Making data dance and developers believe.
"To debug, to hash," it sang with glee,
"In messenger.rs, improvements you'll see!"
🌟📜

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 0c2a715 and 6f02025.

Files selected for processing (1)

• lightning/src/onion_message/messenger.rs (4 hunks)

Additional comments: 5

lightning/src/onion_message/messenger.rs (5)

• 416-416: The Hash and Debug traits have been correctly added to the Destination enum.
• 443-443: The Hash and Debug traits have been correctly added to the SendSuccess enum.
• 456-456: The Hash and Debug traits have been correctly added to the SendError enum.
• 526-526: The Debug trait has been correctly added to the PeeledOnion enum.
• 413-419: > 📝 NOTE

This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [1-1035]

Overall, the rest of the file outside the specific changes to enums does not contain modifications as part of this PR. The existing logic, structure, and implementations remain unchanged.

[codecov-commenter]

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (71c0d56) 89.10% compared to head (6f02025) 89.13%.
Report is 12 commits behind head on main.

Files	Patch %	Lines
lightning/src/onion_message/messenger.rs	0.00%	2 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
+ Coverage   89.10%   89.13%   +0.03%     
==========================================
  Files         115      115              
  Lines       94105    94106       +1     
  Branches    94105    94106       +1     
==========================================
+ Hits        83853    83883      +30     
+ Misses       7772     7740      -32     
- Partials     2480     2483       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dunxen]

LGTM

CI failing for unrelated MSRV reasons again.

EDIT: Just saw 2891