Replace the generic parse_int_be with a macro called twice
#2934
+35
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`lightning-invoice` was mostly written before std's `from_be_bytes` was stabilized, so used its own `to_int_be` utility to do int conversions from `u8` arrays. Now that the std option has been stable for quite some time, we should juse use it instead.
`parse_int_be` is generic across integer types and also input types, but to do so it relies on the `num-traits` crate. There's not a lot of reason for this now that std has `from_be_bytes`, so we drop the generic now and replace it with a macro which is called twice to create two functions, both only supporting conversion from `u5` arrays.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2934 +/- ##
==========================================
- Coverage 89.20% 89.19% -0.01%
==========================================
Files 117 117
Lines 95513 95513
Branches 95513 95513
==========================================
- Hits 85203 85197 -6
- Misses 7822 7833 +11
+ Partials 2488 2483 -5 ☔ View full report in Codecov by Sentry. |
tnull
approved these changes
Mar 21, 2024
|
Should we go ahead and remove the macro and Edit: nvm, read the PR description more carefully. |
valentinewallace
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parse_int_beis generic across integer types and also inputtypes, but to do so it relies on the
num-traitscrate. There'snot a lot of reason for this now that std has
from_be_bytes, sowe drop the generic now and replace it with a macro which is called
twice to create two functions, both only supporting conversion from
u5arrays.