Make OutputSweeper::track_spendable_outputs fallible
#3015
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3015 +/- ##
==========================================
- Coverage 89.15% 89.12% -0.03%
==========================================
Files 118 118
Lines 97678 97678
Branches 97678 97678
==========================================
- Hits 87080 87060 -20
- Misses 8357 8374 +17
- Partials 2241 2244 +3 ☔ View full report in Codecov by Sentry. |
.. as otherwise we might only log an error and continue if we fail to persist the sweeper state.
tnull
force-pushed
the
2024-04-sweeper-error-on-persistence-failure
branch
from
c4b1c5c to
afb452a
Compare
jkczyz
approved these changes
Apr 24, 2024
|
Hmm, the benchmark failure is unrelated it seems, but I'm not sure why it's flaky? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.. as otherwise we might only log an error and continue if we fail to persist the sweeper state.
This came up during the LDK Node upgrade to 0.0.123-beta. It's nice for the user to be sure that during migration the sweeper has been successfully persisted before it can safely remove the previously-persisted output information.