Skip to content

Add Storable Helper Object #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Add Storable Helper Object #13

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e484c76
Add Storable Helper Object
G8XSU Sep 21, 2023
13d8758
Patch release 0.1.1
G8XSU Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[package]
name = "vss-client"
version = "0.1.0"
version = "0.1.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would generally prefer to have releases in separate PRs. Also, do we want to start a CHANGELOG to mention what was included in each release?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

releases in separate PRs.

This is just a patch release, there are no users, i don't think it makes any difference and is unnecessary.

I don't think CHANGELOG is required until we have an alpha or rc release.
Everything is part of vss-client core functionality. It is equivalent to overwriting 0.1.0, but sadly cargo doesn't allow that.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a patch release, there are no users, i don't think it makes any difference and is unnecessary.

I don't think CHANGELOG is required until we have an alpha or rc release. Everything is part of vss-client core functionality. It is equivalent to overwriting 0.1.0, but sadly cargo doesn't allow that.

Yeah, we can have a more formal process then.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think CHANGELOG is required until we have an alpha or rc release. Everything is part of vss-client core functionality. It is equivalent to overwriting 0.1.0, but sadly cargo doesn't allow that.

SGTM

license = "MIT OR Apache-2.0"
edition = "2021"
homepage = "https://lightningdevkit.org/"
Expand Down