-
Notifications
You must be signed in to change notification settings - Fork 103
Add nightly schedule to Docker CD workflow #813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nightly schedule to Docker CD workflow #813
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would now push a tag called master
every night, which isn't what we want.
Yeah this needs to be constrained further, for now we just want that side branch. |
This commit renames the environment variables to be more accurate and less confusing.
This commit allows us to have different values for the git tag that is checked out (RELEASE_VERSION) and the image tag that we push (IMAGE_TAG).
cc8d54b
to
b02f8da
Compare
Pushed up some fixes. According to the documentation:
Which is why this is going into the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Added a daily schedule to the Docker workflow to automate builds and pushes of the `daily-testing` image. This change introduces a new cron job that runs every day at midnight (UTC) and triggers the workflow.
b02f8da
to
2c60753
Compare
Nightly builds will be published to this Docker Hub page Should occur in ~7 hours |
Added a daily schedule to the Docker workflow to automate builds and
pushes of the
daily-testing
image. This change introduces a new cronjob that runs every day at midnight (UTC) and triggers the workflow.
Additionally, updated the workflow to set different environment
variables for daily builds, including
RELEASE_VERSION
andIMAGE_TAG
.These changes enable the automatic creation of daily testing images with
unique tags.
Inspired by:
https://github.com/lightningnetwork/lnd/blob/57a5e4912bced63ce13be06896f64d7e476616b4/.github/workflows/docker.yml#L7-L44