Skip to content

Add nightly schedule to Docker CD workflow #813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 14, 2024

Conversation

dstadulis
Copy link

Added a daily schedule to the Docker workflow to automate builds and
pushes of the daily-testing image. This change introduces a new cron
job that runs every day at midnight (UTC) and triggers the workflow.

Additionally, updated the workflow to set different environment
variables for daily builds, including RELEASE_VERSION and IMAGE_TAG.
These changes enable the automatic creation of daily testing images with
unique tags.

Inspired by:
https://github.com/lightningnetwork/lnd/blob/57a5e4912bced63ce13be06896f64d7e476616b4/.github/workflows/docker.yml#L7-L44

@dstadulis dstadulis requested review from Roasbeef and guggero August 8, 2024 20:24
Copy link
Member

@guggero guggero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would now push a tag called master every night, which isn't what we want.

@Roasbeef
Copy link
Member

Yeah this needs to be constrained further, for now we just want that side branch.

This commit renames the environment variables to be more accurate and
less confusing.
This commit allows us to have different values for the git tag that is
checked out (RELEASE_VERSION) and the image tag that we push
(IMAGE_TAG).
@guggero guggero force-pushed the cd-nightly-docker-builds branch from cc8d54b to b02f8da Compare August 14, 2024 07:23
@guggero
Copy link
Member

guggero commented Aug 14, 2024

Pushed up some fixes. According to the documentation:

Note: This event will only trigger a workflow run if the workflow file is on the default branch.

Which is why this is going into the master branch, even though it will only build from the 0-19-staging branch.

Copy link
Member

@ellemouton ellemouton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Added a daily schedule to the Docker workflow to automate builds and
pushes of the `daily-testing` image. This change introduces a new cron
job that runs every day at midnight (UTC) and triggers the workflow.
@guggero guggero force-pushed the cd-nightly-docker-builds branch from b02f8da to 2c60753 Compare August 14, 2024 07:59
@guggero guggero merged commit 303312c into lightninglabs:master Aug 14, 2024
10 of 13 checks passed
@dstadulis
Copy link
Author

dstadulis commented Aug 14, 2024

Nightly builds will be published to this Docker Hub page
https://hub.docker.com/r/lightninglabs/lightning-terminal-nightly

Should occur in ~7 hours

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants