Skip to content

upgrade to grpc 1.2.0 everywhere #107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2017
Merged

Conversation

danielamiao
Copy link
Contributor

No description provided.

@joeblubaugh
Copy link
Contributor

Is the bug that part of GRPC was on 1.2 and parts were still on 1.1.0?

Can we group these in the dependency block or use a variable so that they're kept in sync?

@danielamiao
Copy link
Contributor Author

yeah one of the test dependencies was still on 1.1.1 - there are 3 separate build.gradle files "common" , "jre" and "android" so can't group them together, might be possible to use a variable as you suggested, I'll look into it (though it'll go away once we split these repos)

@joeblubaugh
Copy link
Contributor

I think it's reasonable to have separate variables in each build file, or just be cognizant of this problem. Exporting these values from an inner dependency out is likely to be a mess.

@danielamiao
Copy link
Contributor Author

Sounds good - it's good practice to convert all version literals into variables and group them together in each build.gradle file, I'll also add a comment next to the GRPC version (to remind us that the versions likely need to be synced across the 3 files)

@danielamiao danielamiao merged commit 544354f into master Jun 19, 2017
@danielamiao danielamiao deleted the dym/grpc-1.2.0-everywhere branch June 19, 2017 18:52
frenchfrywpepper pushed a commit that referenced this pull request Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants