Propagate sampled flag in-process and improve docs #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iredelmeier
approved these changes
Oct 28, 2019
|
@iredelmeier and @austinlparker thanks for your approvals earlier. I added an additional commit to use the most significant bytes for trace id and pad the least significant bytes as discussed during our meeting earlier. Do you mind giving a 👍 if this is still approved with the additional changes? |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#86 added support for B3 and handles the sampling flag properly at inject and extract sites, but the sampling flag wasn't being propagated properly in-process. This PR fixes that and improves the docs around configuring custom propagation format.