Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ember-cli config file promise is not resolved. #365

Closed
chriseppstein opened this issue Dec 11, 2019 · 3 comments
Closed

ember-cli config file promise is not resolved. #365

chriseppstein opened this issue Dec 11, 2019 · 3 comments
Assignees
@abritinthebay

Comments

@chriseppstein
Copy link
Contributor

The config.search() method returns a promise, but there's no await at

https://github.com/linkedin/css-blocks/blob/master/packages/%40css-blocks/ember-cli/index.js#L285
@chriseppstein
Copy link
Contributor Author

We should add a synchronous mode to the config module.

@abritinthebay
Copy link
Contributor

on it 😄

@abritinthebay abritinthebay self-assigned this Jan 21, 2020
@abritinthebay
Copy link
Contributor

Note: due to that transform extensively uses Dynamic Import, making config support sync is... not likely a small task/possible as-is.

abritinthebay pushed a commit that referenced this issue Jan 21, 2020
fix(ember-cli): Fixes #365, now handles the promise from config.search.
c92f398
@abritinthebay abritinthebay mentioned this issue Jan 21, 2020
Closed
chriseppstein added a commit that referenced this issue Apr 17, 2020
@chriseppstein
feat: Make configuration loading synchronous with async wrapper.
7105d10 
Closes #365.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abritinthebay abritinthebay

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ember-cli): Fixes #365, now handles the promise from config.search. linkedin/css-blocks
2 participants
@chriseppstein @abritinthebay