chore: Update all dependencies. #168
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2018 09:46
This reverts commit 2afc59c.
|
Some tsc fails, what could be the cause? Fix typings or upgrade tsc? |
|
I just did this for opticss last night. Thanks for trying to tackle it. I noticed that @types/webpack is 4.x and webpack is 3.8 so that's probably going to cause some issues. I'll try running the build after I'm done whacking on opticss and see what the issues are. |
|
That sounds good, thanks =) |
|
@DanielRuf Thanks for the patch! That compilation error was weird, but that code shouldn't have been being compiled in that project anyway. We have other projects where TSX is properly compiled during the build. I fixed it by just ignore that directory ;) |
|
Probably some tslint misconfiguration. Not yet sure. Ok =) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also fixes the Node.js 10 setup.