Ember cli classic – merge take 2 #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Works with Ember apps using Module Unification - Dummy app works with CSS Blocks - Modify glimmer analyzer to use more concepts from Glimmer's template tree analysis package. - Broccoli plugin cleans up blocks files correctly now. - Glimmer playground demo uses updated ember-cli addon.
- Make work with dummy apps. - Delivers runtime helpers (currently in "tmp.js" file, Ember isn't resolving the helpers correctly...)
- Each working tree has its own Analyzer and Transport now. - Transport objects are now backed by a Class with a reset method. - Re-organized addon to use functional getEnv and getOptions methods.
- Enable Broccoli build integration to control Analyzer's root directory. - Remove the need for srcDir and rootDir discovery in ember-cli addon by using brococli tmp dirs. - Use sync fs methods.
Allows Broccoli to pass working directory at runtime without creating the analyzer instance.
- Glimmer helpers re-named to sensable private name. - Helper runtimes are injected by ember-cli addon. - Abstracted helper names out of runtime tests for maintainability. - Full test suite passes again and @css-blocks/ember-cli tests helper delivery.
- Added test case routes to dummy app with Acceptance tests. - Added BEM_UNIQUE output mode where BEM classes are guarenteed unique within the same process. - Improved output css-blocks aggregator and cleaned up some of the shared memory constructs. - Fixed css output duplication bugs. - Fixed bugs with autoreload. - Made addon work with in-repo dummy addons.
- Eager engines work and have tests. - Skipped tests for lazy engines. - Bumped ember-cli and associated packages to 3.3.0. - Improve transport object and analysis lookup system.
- fix: Auto-discover common preprocessor extensions for output file. - test: Add failing test page for node modules resolution use case.
|
Now that it is merged in master, can we use css-blocks in an ember.js app ? |
|
Because its still pre-1.0 feel free to use it, but at your own risk 🙂Would definitely appreciate some help kicking the wheels a bit and seeing what breaks. Give the addon's readme a read and see if, even with the caveats, it will work for your use cases right now. I expect most of those six outstanding items to be finished in the next few months. I'll have RFC issues for all six up this week. Its also not published yet! Waiting on @chriseppstein to cut a beta version of the addon. |
benkingcode
reviewed
Aug 15, 2018
| @@ -6,7 +6,10 @@ language: node_js | |||
|
|
|||
| node_js: | |||
| - "8" | |||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
Looks like this git conflict accidentally made it in!
There was a problem hiding this comment.
😫 Lets pretend this never happened...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I screwed up pulling in #185... it was pointing at a branch that wasn't master ¯\(ツ)/¯
Lets do this again.