fix(broccoli): Rebuild diffs input changes and output patch separately. #197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amiller-gh
force-pushed
the
broccoli-rebuild-fix
branch
from
312c050 to
5838e53
Compare
amiller-gh
commented
Sep 11, 2018
packages/@css-blocks/glimmer/test/recursive-template-dependencies-test.ts
Show resolved
Hide resolved
amiller-gh
force-pushed
the
broccoli-rebuild-fix
branch
3 times, most recently
from
eb33c53 to
7548289
Compare
|
@chriseppstein this makes CI green and fixes a pretty big bug with the ember-cli addon. Once in I'll release |
chriseppstein
suggested changes
Sep 12, 2018
packages/@css-blocks/ember-cli/tests/dummy/app/styles/node-modules-resolution.block.css
Outdated
Show resolved
Hide resolved
packages/@css-blocks/ember-cli/tests/dummy/lib/in-repo-addon/package.json
Show resolved
Hide resolved
packages/@css-blocks/glimmer/test/recursive-template-dependencies-test.ts
Show resolved
Hide resolved
chriseppstein
approved these changes
Sep 13, 2018
|
Approved pending the addition of test(s) for the primary issue this addresses. |
amiller-gh
force-pushed
the
broccoli-rebuild-fix
branch
from
8a3ccf4 to
5ac67d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug where changes are occasionally not picked up.