Skip to content

Vs code importer #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 12, 2019
Merged

Vs code importer #348

merged 5 commits into from
Nov 12, 2019

Conversation

ramitha
Copy link
Contributor

@ramitha ramitha commented Nov 8, 2019

No description provided.

jackson-dean
jackson-dean reviewed Nov 9, 2019
View reviewed changes
Copy link
Collaborator

@jackson-dean jackson-dean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! I was wondering how exactly the importer would be implemented, but now that I see this it makes sense :) Just had a few questions

chriseppstein
chriseppstein approved these changes Nov 9, 2019
View reviewed changes
Copy link
Contributor

@chriseppstein chriseppstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Ramitha, this looks great and it's going to make the editing experience a lot more consistent!

There's a few comments. Once those are resolved, you can merge this in!

@chriseppstein chriseppstein merged commit 19a2543 into master Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackson-dean jackson-dean jackson-dean left review comments

@chriseppstein chriseppstein chriseppstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ramitha @chriseppstein @jackson-dean