State containers refactor #73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After spending considerable time exploring this new structure, I found the BlockTree abstraction mostly obfuscated the connections between core models of the Block (Block, Class, and State). By keeping the Inheritable data type and going directly to the concrete classes without an intermediate abstraction, we're still able to keep the Block types split up, but have less cognitive overhead while navigating the data model.
amiller-gh
reviewed
Feb 27, 2018
| never | ||
| > { | ||
| // tslint:disable-next-line:prefer-whatever-to-any | ||
| public lookup(_path: string, _errLoc?: SourceLocation | undefined): Inheritable<any, any, any, any> | undefined { |
There was a problem hiding this comment.
Can use AnyNode here to avoid the lint disable
|
I'm happy with this! Strikes a nice middle ground between my completely abstracted approach and the realities of css-blocks' data structures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After spending considerable time exploring this new structure, I found the BlockTree abstraction mostly obfuscated the connections between core models of the Block (Block, Class, and State). By keeping the Inheritable data type and going directly to the concrete classes without an intermediate abstraction, we're still able to keep the Block types split up, but have less cognitive overhead while navigating the data model.
Since I didn't really know what I thought would be a better approach I wasn't sure exactly how to describe in a code review what to change, so I decided to refactor the code until it "felt more right".
So this is my PR to augment https://github.com/css-blocks/css-blocks/pull/71
There's still a couple failing tests and it depends on a new function in
@opticss/utilto work (css-blocks/opticss@3f63bf2).