Process events that get updated #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When identical events are emitted for a resource, kube-apiserver updates the previous event and increments the count field to represent how many times an event occurred. This is to optimize storage on ETCD. Such consolidation results in an `update` on the event. Currently, the events exporter doesn't process any events that get updated so when similar events re-occur, they aren't processed. This change enables processing events that get updated.
dlessa-li
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When identical events are emitted for a resource, kube-apiserver updates the previous event and increments the count field to represent how many times an event occurred. This is to optimize storage on ETCD. Such consolidation results in an
updateon the event.Currently, the events exporter doesn't process any events that get updated so when similar events re-occur, they aren't processed. This change enables processing events that get updated.
Details
This PR is porting the fix mentioned here: resmoio#168.
Thanks to @Teng-Jiao-Chen for identifying the issue and the fix.
Tests
Tested as mentioned here: resmoio#168