Adds same HEALTHCHECK from official PMS Container (linked) #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds HEALTHCHECK logic from Plex Official Docker: https://github.com/plexinc/pms-docker/blob/master/root/healthcheck.sh
|
Thanks for the PR and putting in the effort, but I refer to the maintainer of the official Docker images: In general until Docker as an organization sets healthchecks in their own official images at a Dockerfile level we will not be adopting the concept either. As stated in that comment the health checks can be added in your own compose file if you want to use them: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds HEALTHCHECK logic from Plex Official Docker: https://github.com/plexinc/pms-docker/blob/master/root/healthcheck.sh
We welcome all PR’s though this doesn’t guarantee it will be accepted.
Description:
Just adds a simple health check.
Benefits of this PR and context:
Adds the ability for users to run autoheal for monitoring and restarting the container automatically: https://github.com/willfarrell/docker-autoheal
How Has This Been Tested?
Forked you project and added the command to dockerfile myself and ensured it returned a healthy value. and it's been in use my the official Plex docker image for quite a while.
Source / References: