chore(deps): update go-git.v4 to go-git/v5 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @llorllale!
I wanted to raise this PR (a draft for now) towards an effort to eliminate a dependency
gopkg.in/src-d/go-git.v4 v4.10.0and replace it withgb.xjqchip.workers.dev/go-git/go-git/v5 v5.11.0. This is in a bid to eliminate a couple of vulnerabilities being reported because ofgopkg.in/src-d/go-git.v4 v4.10.0; a sample of this may be seen in the screenshot below.https://devhub.checkmarx.com/cve-details/CVE-2023-49568/
https://devhub.checkmarx.com/cve-details/CVE-2023-49569/
Background
For some background on this, I work with a few repos which use
go-gitlintas a dependency, which is causinggopkg.in/src-d/go-git.v4 v4.10.0to be added as an indirect dependency, and we have the aforementioned vulnerabilities being reported as Dependabot alerts in our repos. Though we havego-git/v5in the list of dependencies ingo.modtoo, upon running the following command in our repositorieswe see the result as
which is why I thought of creating this PR to fix this issue in
go-gitlint.Checks
I find that the guidelines in
README.mdstate one would need to make sure thatmake checksworks before raising a PR, but I unfortunately haven't been able to see it succeeding, owing to a major difference in dependencies I use on my device, and the versions used in this repo. Would it be possible to have CI checks run on this PR to see if things work? I'd also love if you can guide me in the right direction (or add any commits, to help me too :)) to have this resolved, so this can fix vulnerabilities in this repo, and dependent ones too :)