CIRGen support for `__builtin_elementwise_exp` #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

FantasqueX opened this issue Feb 20, 2025 · 0 comments · Fixed by #1376

Collaborator

FantasqueX commented Feb 20, 2025

This is a sub-issue of #1192
I'll try to implement it these days.

FantasqueX mentioned this issue

[CIR][CIRGen] handle __builtin_elementwise_exp #1376

Merged

bcardosolopes closed this as completed in

6492b9b

lanza pushed a commit that referenced this issue


          [CIR][CIRGen] handle __builtin_elementwise_exp (#1376)

5f1f57c

Original Clang's implementation: 

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L4131-L4133

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L762-L776

Compared with non-elementwise exp

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L3006-L3016

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L669-L685
elementwise version doesn't handle constrained situation. I'm not sure
whether it is intended.

For renaming, it is to match original clang's implementation closely.



Resolves: #1375

xlauko pushed a commit to trailofbits/instafix-llvm that referenced this issue


          [CIR][CIRGen] handle __builtin_elementwise_exp (llvm#1376)

9ac0b75

Original Clang's implementation: 

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L4131-L4133

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L762-L776

Compared with non-elementwise exp

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L3006-L3016

https://github.com/llvm/clangir/blob/2df2022c90e00c0eac542eba4078e79306155c7b/clang/lib/CodeGen/CGBuiltin.cpp#L669-L685
elementwise version doesn't handle constrained situation. I'm not sure
whether it is intended.

For renaming, it is to match original clang's implementation closely.



Resolves: llvm/clangir#1375

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment