Skip to content

Reinstate #668 and #678 #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bcardosolopes opened this issue Jun 17, 2024 · 2 comments · Fixed by #697
Closed

Reinstate #668 and #678 #691

bcardosolopes opened this issue Jun 17, 2024 · 2 comments · Fixed by #697
Assignees

Comments

@bcardosolopes
Copy link
Member

#668 broke the build and had to be reverted (tks @dkolsen-pgi for catching it)

/usr/bin/ld: lib/libMLIRCIRTransforms.a(LoweringPrepare.cpp.o): in function `(anonymous namespace)::LoweringPreparePass::lowerVAArgOp(mlir::cir::VAArgOp)':
/local/home/dolsen/clangir/clang/lib/CIR/Dialect/Transforms/LoweringPrepare.cpp:340: undefined reference to `cir::CIRDataLayout::CIRDataLayout(mlir::ModuleOp)'
/usr/bin/ld: lib/libTargetLowering.a(LowerTypes.cpp.o): in function `cir::CIRDataLayout::CIRDataLayout(llvm::StringRef, mlir::ModuleOp)':
/local/home/dolsen/clangir/clang/include/clang/CIR/Dialect/IR/CIRDataLayout.h:31: undefined reference to `cir::CIRDataLayout::reset(llvm::StringRef)'`'

Steps to reproduce:

$ cmake -GNinja -DCMAKE_INSTALL_PREFIX=/<some-path>/clangir-install "-DLLVM_ENABLE_PROJECTS=clang;mlir" -DCLANG_ENABLE_CIR=ON -DLLVM_TARGETS_TO_BUILD=host -DCMAKE_BUILD_TYPE=Debug ../clangir/llvm
$ ninja install

Creating the issue to track re-landing the work once this is fixed.

@bcardosolopes
Copy link
Member Author

Reverted in
47df94c
e91ada4

@dkolsen-pgi
Copy link
Collaborator

When the changes that were reverted are redone, I believe (but am not certain) that some of the new code will need to go into a different file.

bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this issue Oct 2, 2024
Essentially re-applies llvm#668 and llvm#678, but also includes llvm#687 which
patched build introduced by the other two PRs.

Closes llvm#691
Hugobros3 pushed a commit to shady-gang/clangir that referenced this issue Oct 2, 2024
Essentially re-applies llvm#668 and llvm#678, but also includes llvm#687 which
patched build introduced by the other two PRs.

Closes llvm#691
smeenai pushed a commit to smeenai/clangir that referenced this issue Oct 9, 2024
Essentially re-applies llvm#668 and llvm#678, but also includes llvm#687 which
patched build introduced by the other two PRs.

Closes llvm#691
keryell pushed a commit to keryell/clangir that referenced this issue Oct 19, 2024
Essentially re-applies llvm#668 and llvm#678, but also includes llvm#687 which
patched build introduced by the other two PRs.

Closes llvm#691
lanza pushed a commit that referenced this issue Nov 5, 2024
Essentially re-applies #668 and #678, but also includes #687 which
patched build introduced by the other two PRs.

Closes #691
lanza pushed a commit that referenced this issue Mar 18, 2025
Essentially re-applies #668 and #678, but also includes #687 which
patched build introduced by the other two PRs.

Closes #691
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants