Fix XFAIL in hello.cir #913
Labels
Comments
smeenai
added a commit
to smeenai/clangir
that referenced
this issue
Oct 8, 2024
After 5da4310, the LLVM dialect requires the variadic callee type to be present for variadic calls. The op builders take care of this automatically if you pass the function type, so change our lowering logic to do so. Add tests for this as well as a missing test for indirect function call lowering. Fixes llvm#913 Fixes llvm#933
smeenai
added a commit
to smeenai/clangir
that referenced
this issue
Oct 9, 2024
After 5da4310, the LLVM dialect requires the variadic callee type to be present for variadic calls. The op builders take care of this automatically if you pass the function type, so change our lowering logic to do so. Add tests for this as well as a missing test for indirect function call lowering. Fixes llvm#913 Fixes llvm#933
smeenai
added a commit
to smeenai/clangir
that referenced
this issue
Oct 9, 2024
After 5da4310, the LLVM dialect requires the variadic callee type to be present for variadic calls. The op builders take care of this automatically if you pass the function type, so change our lowering logic to do so. Add tests for this as well as a missing test for indirect function call lowering. Fixes llvm#913 Fixes llvm#933
smeenai
added a commit
to smeenai/clangir
that referenced
this issue
Oct 9, 2024
After 5da4310, the LLVM dialect requires the variadic callee type to be present for variadic calls. The op builders take care of this automatically if you pass the function type, so change our lowering logic to do so. Add tests for this as well as a missing test for indirect function call lowering. Fixes llvm#913 Fixes llvm#933
keryell
pushed a commit
to keryell/clangir
that referenced
this issue
Oct 19, 2024
After 5da4310, the LLVM dialect requires the variadic callee type to be present for variadic calls. The op builders take care of this automatically if you pass the function type, so change our lowering logic to do so. Add tests for this as well as a missing test for indirect function call lowering. Fixes llvm#913 Fixes llvm#933
lanza
pushed a commit
that referenced
this issue
Nov 5, 2024
After 5da4310, the LLVM dialect requires the variadic callee type to be present for variadic calls. The op builders take care of this automatically if you pass the function type, so change our lowering logic to do so. Add tests for this as well as a missing test for indirect function call lowering. Fixes #913 Fixes #933
lanza
pushed a commit
that referenced
this issue
Mar 18, 2025
After 5da4310, the LLVM dialect requires the variadic callee type to be present for variadic calls. The op builders take care of this automatically if you pass the function type, so change our lowering logic to do so. Add tests for this as well as a missing test for indirect function call lowering. Fixes #913 Fixes #933
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
During rebasing this test began to fail.
The text was updated successfully, but these errors were encountered: