Skip to content

[CIR][CIRGen] Add support for abs #1011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Oct 30, 2024
Merged

[CIR][CIRGen] Add support for abs #1011

merged 9 commits into from
Oct 30, 2024

Conversation

PikachuHyA
Copy link
Collaborator

This patch introduces support for the abs family of built-in functions (abs, labs, llabs).

Lancern
Lancern requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! Some comments inline.

bcardosolopes
bcardosolopes requested changes Oct 28, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this! @Lancern raised really good points

@bcardosolopes bcardosolopes changed the title [CIR][CIRGen] support abs [CIR][CIRGen] Add support for abs Oct 28, 2024
@PikachuHyA
Copy link
Collaborator Author

Thanks for your comments.

I have updated the code. please review again.

Lancern
Lancern approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this. Some further nits inline and the rest LGTM!

bcardosolopes
bcardosolopes requested changes Oct 29, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remaining thing needs fixing! Thanks

@bcardosolopes bcardosolopes merged commit 5404e9c into llvm:main Oct 30, 2024
6 checks passed
lanza pushed a commit that referenced this pull request Nov 5, 2024
@PikachuHyA @lanza
[CIR][CIRGen] Add support for abs (#1011)
f11da35 
This patch introduces support for the abs family of built-in functions
(abs, labs, llabs).
@PikachuHyA PikachuHyA deleted the shuoshu_github_patch branch November 18, 2024 01:49
lanza pushed a commit that referenced this pull request Mar 18, 2025
@PikachuHyA @lanza
[CIR][CIRGen] Add support for abs (#1011)
bdd3e45 
This patch introduces support for the abs family of built-in functions
(abs, labs, llabs).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

@Lancern Lancern Lancern approved these changes

@lanza lanza Awaiting requested review from lanza lanza is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@PikachuHyA @bcardosolopes @Lancern