[CIR][CodeGen][LowerToLLVM] String literals for OpenCL #1091
+119
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Nov 8, 2024
seven-mile
force-pushed
the
str-lit-opencl
branch
from
0808fab to
b2dc501
Compare
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
This PR supports string literals in OpenCL end to end, making it possible to use `printf`. This involves two changes: * In CIRGen, ensure we create the global symbol for string literals with correct `constant` address space. * In LowerToLLVM, make the lowering of `GlobalViewAttr` aware of the upstream address space. Other proper refactors are also applied. Two test cases from OG CodeGen are reused. `str_literals.cl` is the primary test, while `printf.cl` is the bonus one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR supports string literals in OpenCL end to end, making it possible to use
printf. This involves two changes:constantaddress space.GlobalViewAttraware of the upstream address space.Other proper refactors are also applied.
Two test cases from OG CodeGen are reused.
str_literals.clis the primary test, whileprintf.clis the bonus one.