[CIR] Implement ::verify for cir.atomic.xchg and cir.atomic.cmp_xchg #1431
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bcardosolopes is this the expected result? Failure at |
bcardosolopes
requested changes
Mar 5, 2025
|
@bcardosolopes I corrected the code where requested and added the tests ( |
|
I'll land once tests pass |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
clang-format issues need fixing before landing! |
|
Done! |
|
@bcardosolopes I believe everything was fixed! |
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
…1431) Implements `::verify` for operations cir.atomic.xchg and cir.atomic.cmp_xchg I believe the existing regression tests don't get to the CIR level type check failure and I was not able to implement a case that does. Most attempts of reproducing cir.atomic.xchg type check failure were along the lines of: ``` int a; long long b,c; __atomic_exchange(&a, &b, &c, memory_order_seq_cst); ``` And they seem to never trigger the failure on `::verify` because they fail earlier in function parameter checking: ``` exmp.cpp:7:27: error: cannot initialize a parameter of type 'int *' with an rvalue of type 'long long *' 7 | __atomic_exchange(&a, &b, &c, memory_order_seq_cst); | ^~ ``` Closes #1378 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
::verifyfor operations cir.atomic.xchg and cir.atomic.cmp_xchgI believe the existing regression tests don't get to the CIR level type check failure and I was not able to implement a case that does.
Most attempts of reproducing cir.atomic.xchg type check failure were along the lines of:
And they seem to never trigger the failure on
::verifybecause they fail earlier in function parameter checking:Closes #1378 .