Skip to content

[CIR] Infer MLIR context in type builders when possible #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xlauko
Copy link
Collaborator

@xlauko xlauko commented Apr 18, 2025

Add TypeBuilderWithInferredContext to each CIR type that supports MLIR context inference from its parameters.

@xlauko
Copy link
Collaborator Author

xlauko commented Apr 18, 2025

@xlauko xlauko requested a review from bcardosolopes April 18, 2025 13:28
@xlauko xlauko self-assigned this Apr 18, 2025
@xlauko xlauko marked this pull request as ready for review April 18, 2025 13:31
@xlauko xlauko requested a review from lanza as a code owner April 18, 2025 13:31
@xlauko
Copy link
Collaborator Author

xlauko commented Apr 18, 2025

I will apply same changes to upstream when this is merged.

@xlauko xlauko force-pushed the users/xlauko/type-builders-with-inferred-context branch from 69e6dbb to 3ae73cd Compare April 18, 2025 13:49
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the cleanup!

@bcardosolopes bcardosolopes merged commit 0bae1fd into main Apr 18, 2025
9 checks passed
xlauko added a commit to llvm/llvm-project that referenced this pull request Apr 19, 2025
llvm-sync bot pushed a commit to arm/arm-toolchain that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants