Skip to content

[CIR][CIRGen] Generate 80-bit long doubles #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

sitio-couto
Copy link
Collaborator

Uses the already builtin types to generate the long double 80-bit variant present in x86/x87 ISA.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we already have an issue to track adding CIR types for floats?

LGTM with some nitpicks.

Uses the builtin types to generate the long double 80-bit variant
present in x86/x87 ISA.
@sitio-couto sitio-couto force-pushed the vinicius/long-doubles branch from 20252ac to 4a82a08 Compare July 26, 2023 12:23
@sitio-couto
Copy link
Collaborator Author

Do we already have an issue to track adding CIR types for floats?

We do. It's #78.

@sitio-couto sitio-couto merged commit f3a708d into llvm:main Jul 26, 2023
@sitio-couto sitio-couto deleted the vinicius/long-doubles branch November 14, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants