Skip to content

[CIR][LLVMLowering] Lower cir.objectsize #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Conversation

ghehg
Copy link
Collaborator

@ghehg ghehg commented Apr 16, 2024

lowering cir.objectsize to llvm.objectsize

@bcardosolopes bcardosolopes changed the title [CIR] [LLVMLowering] Lower cir.objectsize [CIR][LLVMLowering] Lower cir.objectsize Apr 16, 2024
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, few minor changes remaining.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge as soon as the tests pass! Thanks Guojin

@bcardosolopes bcardosolopes merged commit 4dd722a into llvm:main Apr 16, 2024
6 checks passed
bcardosolopes added a commit that referenced this pull request Apr 17, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
lanza pushed a commit that referenced this pull request Apr 29, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
lanza pushed a commit that referenced this pull request Apr 29, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
lanza pushed a commit that referenced this pull request Apr 29, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
lanza pushed a commit that referenced this pull request Apr 29, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
lanza pushed a commit that referenced this pull request Apr 29, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
lanza pushed a commit that referenced this pull request Apr 29, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
lanza pushed a commit that referenced this pull request Nov 5, 2024
Lowers `cir.objectsize` to `llvm.objectsize`
lanza pushed a commit that referenced this pull request Nov 5, 2024
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
lanza pushed a commit that referenced this pull request Mar 18, 2025
Lowers `cir.objectsize` to `llvm.objectsize`
lanza pushed a commit that referenced this pull request Mar 18, 2025
This reverts commit 87a61f3.

It's deleting code it isn't supposed to touch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants