[CIR][CodeGen] Basic skeleton of SPIRV64 target support #671
Conversation
There was a problem hiding this comment.
Hi @seven-mile, thanks for adding this! This is touching a bunch of the things @sitio-couto is working on right now, and it'd be extremely unfortunate if this is all has to be done differently in a few weeks from now. Please coordinate between the two of you how to make sure you don't duplicate work. I'll wait until he can take a look before I give more feedback
|
I tried to make the part about ABI as minimal as possible so that some test cases in OpenCL can land. The ABI implementation is just using |
Direct is fine, but extend might be doing more that it should for now, let's wait on @sitio-couto to coordinate how to go about this so you both are in sync. |
|
@sitio-couto review ping! |
There was a problem hiding this comment.
@bcardosolopes @seven-mile reviewed.
PS: apologies for the late review 😅
There was a problem hiding this comment.
Nit changes from @sitio-couto, but other than that seems fine - @sitio-couto will patch this up once he lands his work
Co-authored-by: Vinicius Couto Espindola <[email protected]>
* SPIRV64 TargetInfo * Calling convention `SPIR_KERNEL` * Minimal ABI with Direct/Extend for arguments and Ignore for return --------- Co-authored-by: Vinicius Couto Espindola <[email protected]>
* SPIRV64 TargetInfo * Calling convention `SPIR_KERNEL` * Minimal ABI with Direct/Extend for arguments and Ignore for return --------- Co-authored-by: Vinicius Couto Espindola <[email protected]>
* SPIRV64 TargetInfo * Calling convention `SPIR_KERNEL` * Minimal ABI with Direct/Extend for arguments and Ignore for return --------- Co-authored-by: Vinicius Couto Espindola <[email protected]>
* SPIRV64 TargetInfo * Calling convention `SPIR_KERNEL` * Minimal ABI with Direct/Extend for arguments and Ignore for return --------- Co-authored-by: Vinicius Couto Espindola <[email protected]>
* SPIRV64 TargetInfo * Calling convention `SPIR_KERNEL` * Minimal ABI with Direct/Extend for arguments and Ignore for return --------- Co-authored-by: Vinicius Couto Espindola <[email protected]>
* SPIRV64 TargetInfo * Calling convention `SPIR_KERNEL` * Minimal ABI with Direct/Extend for arguments and Ignore for return --------- Co-authored-by: Vinicius Couto Espindola <[email protected]>
SPIR_KERNEL