[CIR][CIRGen] Implement unary inc/dec in CIRGenExpr #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just realized I should have more tests for the "post increment" variant. Will add those later today. |
|
Looks great @j2kun, thanks! Will approve the PR but please add the testcases you mentioned before landing. |
bcardosolopes
approved these changes
May 17, 2023
bcardosolopes
changed the title
|
I went ahead and merged given the post-inc tests can come on a later PR (makes sense to split given this PR deals with pre-inc/dec) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the non-complex part of #7