[CIR][Transforms][NFC] Use unique_ptr to encapsulate LowerModule
#752
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Jul 24, 2024
| @@ -36,22 +36,22 @@ struct CallConvLoweringPattern : public OpRewritePattern<FuncOp> { | |||
| return op.emitError("function has no AST information"); | |||
|
|
|||
| auto modOp = op->getParentOfType<ModuleOp>(); | |||
| LowerModule lowerModule = createLowerModule(modOp, rewriter); | |||
| auto lowerModule = createLowerModule(modOp, rewriter); | |||
There was a problem hiding this comment.
This doesn't fit the auto rules from code style (I know, it's annoying =( )
|
Suggestion applied ; ) |
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…lvm#752) Currently `LowerModule` mimics `CodeGenModule` and uses many raw references. It cannot be moved or copied. Value semantic does not fit the need. For example, we cannot pass LowerModule around. A better practice would be to use `unique_ptr` to encapsulate it. In the future, we hold its ownership in some long-lived contexts (it's `CodeGeneratorImpl` for `CodeGenModule`) and pass references to it around safely.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…lvm#752) Currently `LowerModule` mimics `CodeGenModule` and uses many raw references. It cannot be moved or copied. Value semantic does not fit the need. For example, we cannot pass LowerModule around. A better practice would be to use `unique_ptr` to encapsulate it. In the future, we hold its ownership in some long-lived contexts (it's `CodeGeneratorImpl` for `CodeGenModule`) and pass references to it around safely.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…lvm#752) Currently `LowerModule` mimics `CodeGenModule` and uses many raw references. It cannot be moved or copied. Value semantic does not fit the need. For example, we cannot pass LowerModule around. A better practice would be to use `unique_ptr` to encapsulate it. In the future, we hold its ownership in some long-lived contexts (it's `CodeGeneratorImpl` for `CodeGenModule`) and pass references to it around safely.
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…lvm#752) Currently `LowerModule` mimics `CodeGenModule` and uses many raw references. It cannot be moved or copied. Value semantic does not fit the need. For example, we cannot pass LowerModule around. A better practice would be to use `unique_ptr` to encapsulate it. In the future, we hold its ownership in some long-lived contexts (it's `CodeGeneratorImpl` for `CodeGenModule`) and pass references to it around safely.
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
) Currently `LowerModule` mimics `CodeGenModule` and uses many raw references. It cannot be moved or copied. Value semantic does not fit the need. For example, we cannot pass LowerModule around. A better practice would be to use `unique_ptr` to encapsulate it. In the future, we hold its ownership in some long-lived contexts (it's `CodeGeneratorImpl` for `CodeGenModule`) and pass references to it around safely.
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
) Currently `LowerModule` mimics `CodeGenModule` and uses many raw references. It cannot be moved or copied. Value semantic does not fit the need. For example, we cannot pass LowerModule around. A better practice would be to use `unique_ptr` to encapsulate it. In the future, we hold its ownership in some long-lived contexts (it's `CodeGeneratorImpl` for `CodeGenModule`) and pass references to it around safely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
LowerModulemimicsCodeGenModuleand uses many raw references. It cannot be moved or copied. Value semantic does not fit the need. For example, we cannot pass LowerModule around.A better practice would be to use
unique_ptrto encapsulate it. In the future, we hold its ownership in some long-lived contexts (it'sCodeGeneratorImplforCodeGenModule) and pass references to it around safely.