[CIR][ThroughMLIR] Support array type GlobalOp lowering with initial values #753
Conversation
There was a problem hiding this comment.
Awesome, way to go!
Can you please do the refactoring first on a NFC PR and then follow up with the actual change in this PR (or however you want to present these two PRs)? The change kinda sneaks in the refactoring. Since you are changing a function that gets used by both, it'd be nice to add one CIR->LLVM testcase as well (no need to add as much as you add for MLIR, one should be good enough)
Sure, will do. |
ShivaChen
force-pushed
the
global-array-init
branch
from
db456b8 to
4ad09ff
Compare
|
I have created a refactoring PR #754. It turns out the way to fix "array size greater than initial string value" only works for MLIR lowering path. |
…values This commit makes the changes as following. 1. Enable array type GlobalOp lowering with initial values 2. Add error message when array size is not equal to initial string value E.g. char big_string[10] = "abc";
ShivaChen
force-pushed
the
global-array-init
branch
from
4ad09ff to
124d8cf
Compare
…values (llvm#753) This commit makes the changes as following. 1. Enable array type GlobalOp lowering with initial values 2. Add error message when array size is not equal to initial string value size E.g. char big_string[10] = "abc";
…values (llvm#753) This commit makes the changes as following. 1. Enable array type GlobalOp lowering with initial values 2. Add error message when array size is not equal to initial string value size E.g. char big_string[10] = "abc";
…values (llvm#753) This commit makes the changes as following. 1. Enable array type GlobalOp lowering with initial values 2. Add error message when array size is not equal to initial string value size E.g. char big_string[10] = "abc";
…values (llvm#753) This commit makes the changes as following. 1. Enable array type GlobalOp lowering with initial values 2. Add error message when array size is not equal to initial string value size E.g. char big_string[10] = "abc";
…values (#753) This commit makes the changes as following. 1. Enable array type GlobalOp lowering with initial values 2. Add error message when array size is not equal to initial string value size E.g. char big_string[10] = "abc";
…values (#753) This commit makes the changes as following. 1. Enable array type GlobalOp lowering with initial values 2. Add error message when array size is not equal to initial string value size E.g. char big_string[10] = "abc";
This commit makes the changes as following.
Enable array type GlobalOp lowering with initial values
Add error message when array size is not equal to initial string value size
E.g. char big_string[10] = "abc";