Skip to content

[CIR][Transforms] Add folders for complex operations #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

Lancern
Copy link
Member

@Lancern Lancern commented Aug 4, 2024

This PR adds folders for cir.complex.create, cir.complex.real, and cir.complex.imag.

This PR adds a new attribute #cir.complex that represents a constant complex value. Besides, the CIR dialect does not have a constant materializer yet; this PR adds it.

Address #726 .

@Lancern Lancern marked this pull request as draft August 5, 2024 02:06
@Lancern
Copy link
Member Author

Lancern commented Aug 5, 2024

Just forgot the LLVM lowering of cir.const #cir.complex. Adding it to this PR.

@Lancern Lancern marked this pull request as ready for review August 5, 2024 12:51
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall great, just one extra suggestion

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing conflicts

@Lancern
Copy link
Member Author

Lancern commented Aug 8, 2024

Rebased onto the latest main.

This patch adds folderss for `cir.complex.create`, `cir.complex.real`, and
`cir.complex.imag`.

This patch adds a new attribute `#cir.complex` that represents a constant
complex value. Besides, the CIR dialect does not have a constant materializer
yet; this patch adds it.
@bcardosolopes bcardosolopes merged commit 1dfe2f0 into llvm:main Aug 8, 2024
6 checks passed
@Lancern Lancern deleted the complex-fold branch August 9, 2024 01:06
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This PR adds folders for `cir.complex.create`, `cir.complex.real`, and
`cir.complex.imag`.

This PR adds a new attribute `#cir.complex` that represents a constant
complex value. Besides, the CIR dialect does not have a constant
materializer yet; this PR adds it.

Address llvm#726 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR adds folders for `cir.complex.create`, `cir.complex.real`, and
`cir.complex.imag`.

This PR adds a new attribute `#cir.complex` that represents a constant
complex value. Besides, the CIR dialect does not have a constant
materializer yet; this PR adds it.

Address llvm#726 .
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
This PR adds folders for `cir.complex.create`, `cir.complex.real`, and
`cir.complex.imag`.

This PR adds a new attribute `#cir.complex` that represents a constant
complex value. Besides, the CIR dialect does not have a constant
materializer yet; this PR adds it.

Address llvm#726 .
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This PR adds folders for `cir.complex.create`, `cir.complex.real`, and
`cir.complex.imag`.

This PR adds a new attribute `#cir.complex` that represents a constant
complex value. Besides, the CIR dialect does not have a constant
materializer yet; this PR adds it.

Address llvm#726 .
lanza pushed a commit that referenced this pull request Nov 5, 2024
This PR adds folders for `cir.complex.create`, `cir.complex.real`, and
`cir.complex.imag`.

This PR adds a new attribute `#cir.complex` that represents a constant
complex value. Besides, the CIR dialect does not have a constant
materializer yet; this PR adds it.

Address #726 .
lanza pushed a commit that referenced this pull request Mar 18, 2025
This PR adds folders for `cir.complex.create`, `cir.complex.real`, and
`cir.complex.imag`.

This PR adds a new attribute `#cir.complex` that represents a constant
complex value. Besides, the CIR dialect does not have a constant
materializer yet; this PR adds it.

Address #726 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants