Skip to content

[CIR][NFC] Fix mismatch of argument type in IR tests #837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2024
Merged

[CIR][NFC] Fix mismatch of argument type in IR tests #837

merged 1 commit into from
Sep 14, 2024

Conversation

seven-mile
Copy link
Collaborator

There is a typo in call.cir that uses a wrong function argument type, leading to failure in the final LLVM IR translation.

CIR verification does not reject it, because it skips indirect calls at the beginning. It's verifySymbolUses after all.

clangir/clang/lib/CIR/Dialect/IR/CIRDialect.cpp

Lines 2672 to 2679 in bde154c

static LogicalResult
verifyCallCommInSymbolUses(Operation *op, SymbolTableCollection &symbolTable) {
// Callee attribute only need on indirect calls.
auto fnAttr = op->getAttrOfType<FlatSymbolRefAttr>("callee");
if (!fnAttr)
return success();
FuncOp fn =

The typo was copied to another IR test. Here we fix them all.

bcardosolopes
bcardosolopes approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge once the conflict is fixed!

@seven-mile seven-mile force-pushed the fix-ir-test-type-typo branch from 12d3dac to 9177316 Compare September 14, 2024 00:27
@bcardosolopes bcardosolopes merged commit 5da0007 into llvm:main Sep 14, 2024
6 checks passed
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
@seven-mile @lanza
[CIR][NFC] Fix mismatch of argument type in IR tests (llvm#837)
ab4e048 
There is a typo in `call.cir` that uses a wrong function argument type,
leading to failure in the final LLVM IR translation.

CIR verification does not reject it, because it skips indirect calls at
the beginning. It's `verifySymbolUses` after all.


https://github.com/llvm/clangir/blob/bde154cf1243cc4f938339c4dc15b1576d3025ab/clang/lib/CIR/Dialect/IR/CIRDialect.cpp#L2672-L2679

The typo was copied to another IR test. Here we fix them all.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
@seven-mile @smeenai
[CIR][NFC] Fix mismatch of argument type in IR tests (llvm#837)
2dcf9c1 
There is a typo in `call.cir` that uses a wrong function argument type,
leading to failure in the final LLVM IR translation.

CIR verification does not reject it, because it skips indirect calls at
the beginning. It's `verifySymbolUses` after all.


https://github.com/llvm/clangir/blob/bde154cf1243cc4f938339c4dc15b1576d3025ab/clang/lib/CIR/Dialect/IR/CIRDialect.cpp#L2672-L2679

The typo was copied to another IR test. Here we fix them all.
smeenai pushed a commit to smeenai/clangir that referenced this pull request Oct 9, 2024
@seven-mile @smeenai
[CIR][NFC] Fix mismatch of argument type in IR tests (llvm#837)
95c6a7d 
There is a typo in `call.cir` that uses a wrong function argument type,
leading to failure in the final LLVM IR translation.

CIR verification does not reject it, because it skips indirect calls at
the beginning. It's `verifySymbolUses` after all.


https://github.com/llvm/clangir/blob/bde154cf1243cc4f938339c4dc15b1576d3025ab/clang/lib/CIR/Dialect/IR/CIRDialect.cpp#L2672-L2679

The typo was copied to another IR test. Here we fix them all.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
@seven-mile @lanza
[CIR][NFC] Fix mismatch of argument type in IR tests (llvm#837)
143e2a5 
There is a typo in `call.cir` that uses a wrong function argument type,
leading to failure in the final LLVM IR translation.

CIR verification does not reject it, because it skips indirect calls at
the beginning. It's `verifySymbolUses` after all.


https://github.com/llvm/clangir/blob/bde154cf1243cc4f938339c4dc15b1576d3025ab/clang/lib/CIR/Dialect/IR/CIRDialect.cpp#L2672-L2679

The typo was copied to another IR test. Here we fix them all.
lanza pushed a commit that referenced this pull request Nov 5, 2024
@seven-mile @lanza
[CIR][NFC] Fix mismatch of argument type in IR tests (#837)
f87bdeb 
There is a typo in `call.cir` that uses a wrong function argument type,
leading to failure in the final LLVM IR translation.

CIR verification does not reject it, because it skips indirect calls at
the beginning. It's `verifySymbolUses` after all.


https://github.com/llvm/clangir/blob/bde154cf1243cc4f938339c4dc15b1576d3025ab/clang/lib/CIR/Dialect/IR/CIRDialect.cpp#L2672-L2679

The typo was copied to another IR test. Here we fix them all.
lanza pushed a commit that referenced this pull request Mar 18, 2025
@seven-mile @lanza
[CIR][NFC] Fix mismatch of argument type in IR tests (#837)
6097fcd 
There is a typo in `call.cir` that uses a wrong function argument type,
leading to failure in the final LLVM IR translation.

CIR verification does not reject it, because it skips indirect calls at
the beginning. It's `verifySymbolUses` after all.


https://github.com/llvm/clangir/blob/bde154cf1243cc4f938339c4dc15b1576d3025ab/clang/lib/CIR/Dialect/IR/CIRDialect.cpp#L2672-L2679

The typo was copied to another IR test. Here we fix them all.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcardosolopes bcardosolopes bcardosolopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seven-mile @bcardosolopes