Skip to content

[CIR][CIRGen][Builtin] Implement builtin __sync_fetch_and_sub #932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2024
Merged

[CIR][CIRGen][Builtin] Implement builtin __sync_fetch_and_sub #932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions clang/lib/CIR/CodeGen/CIRGenBuiltin.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1164,6 +1164,16 @@ RValue CIRGenFunction::buildBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID,
return buildBinaryAtomic(*this, mlir::cir::AtomicFetchKind::Add, E);
}

case Builtin::BI__sync_fetch_and_sub:
llvm_unreachable("Shouldn't make it through sema");
case Builtin::BI__sync_fetch_and_sub_1:
case Builtin::BI__sync_fetch_and_sub_2:
case Builtin::BI__sync_fetch_and_sub_4:
case Builtin::BI__sync_fetch_and_sub_8:
case Builtin::BI__sync_fetch_and_sub_16: {
return buildBinaryAtomic(*this, mlir::cir::AtomicFetchKind::Sub, E);
}

case Builtin::BI__sync_val_compare_and_swap_1:
case Builtin::BI__sync_val_compare_and_swap_2:
case Builtin::BI__sync_val_compare_and_swap_4:
Expand Down
72 changes: 71 additions & 1 deletion clang/test/CIR/CodeGen/atomic.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,6 +351,19 @@ void inc_int(int* a, int b) {
// LLVM-LABEL: @_Z7inc_int
// LLVM: atomicrmw add ptr {{.*}}, i32 {{.*}} seq_cst, align 4

void sub_int(int* a, int b) {
int c = __sync_fetch_and_sub(a, b);
}

// CHECK-LABEL: _Z7sub_int
// CHECK: %[[PTR:.*]] = cir.load {{.*}} : !cir.ptr<!cir.ptr<!s32i>>, !cir.ptr<!s32i>
// CHECK: %[[VAL:.*]] = cir.load {{.*}} : !cir.ptr<!s32i>, !s32i
// CHECK: %[[RES:.*]] = cir.atomic.fetch(sub, %[[PTR]] : !cir.ptr<!s32i>, %[[VAL]] : !s32i, seq_cst) fetch_first : !s32i
// CHECK: cir.store %[[RES]], {{.*}} : !s32i, !cir.ptr<!s32i>

// LLVM-LABEL: _Z7sub_int
// LLVM: atomicrmw sub ptr {{.*}}, i32 {{.*}} seq_cst, align 4


// CHECK-LABEL: @_Z8inc_long
// CHECK: cir.atomic.fetch(add, {{.*}} : !cir.ptr<!s64i>, {{.*}} : !s64i, seq_cst) fetch_first : !s64i
Expand All @@ -362,6 +375,17 @@ void inc_long(long* a, long b) {
long c = __sync_fetch_and_add(a, 2);
}

// CHECK-LABEL: @_Z8sub_long
// CHECK: cir.atomic.fetch(sub, {{.*}} : !cir.ptr<!s64i>, {{.*}} : !s64i, seq_cst) fetch_first : !s64i

// LLVM-LABEL: @_Z8sub_long
// LLVM: atomicrmw sub ptr {{.*}}, i64 {{.*}} seq_cst, align 8

void sub_long(long* a, long b) {
long c = __sync_fetch_and_sub(a, 2);
}


// CHECK-LABEL: @_Z9inc_short
// CHECK: cir.atomic.fetch(add, {{.*}} : !cir.ptr<!s16i>, {{.*}} : !s16i, seq_cst) fetch_first : !s16i

Expand All @@ -371,6 +395,16 @@ void inc_short(short* a, short b) {
short c = __sync_fetch_and_add(a, 2);
}

// CHECK-LABEL: @_Z9sub_short
// CHECK: cir.atomic.fetch(sub, {{.*}} : !cir.ptr<!s16i>, {{.*}} : !s16i, seq_cst) fetch_first : !s16i

// LLVM-LABEL: @_Z9sub_short
// LLVM: atomicrmw sub ptr {{.*}}, i16 {{.*}} seq_cst, align 2
void sub_short(short* a, short b) {
short c = __sync_fetch_and_sub(a, 2);
}


// CHECK-LABEL: @_Z8inc_byte
// CHECK: cir.atomic.fetch(add, {{.*}} : !cir.ptr<!s8i>, {{.*}} : !s8i, seq_cst) fetch_first : !s8i

Expand All @@ -380,6 +414,14 @@ void inc_byte(char* a, char b) {
char c = __sync_fetch_and_add(a, b);
}

// CHECK-LABEL: @_Z8sub_byte
// CHECK: cir.atomic.fetch(sub, {{.*}} : !cir.ptr<!s8i>, {{.*}} : !s8i, seq_cst) fetch_first : !s8i

// LLVM-LABEL: @_Z8sub_byte
// LLVM: atomicrmw sub ptr {{.*}}, i8 {{.*}} seq_cst, align 1
void sub_byte(char* a, char b) {
char c = __sync_fetch_and_sub(a, b);
}

// CHECK-LABEL: @_Z12cmp_bool_int
// CHECK: %[[PTR:.*]] = cir.load {{.*}} : !cir.ptr<!cir.ptr<!s32i>>, !cir.ptr<!s32i>
Expand Down Expand Up @@ -481,6 +523,15 @@ void inc_uint(unsigned int* a, int b) {
unsigned int c = __sync_fetch_and_add(a, b);
}

// CHECK-LABEL: @_Z8sub_uint
// CHECK: cir.atomic.fetch(sub, {{.*}} : !cir.ptr<!u32i>, {{.*}} : !u32i, seq_cst) fetch_first : !u32i

// LLVM-LABEL: @_Z8sub_uint
// LLVM: atomicrmw sub ptr {{.*}}, i32 {{.*}} seq_cst, align 4
void sub_uint(unsigned int* a, int b) {
unsigned int c = __sync_fetch_and_sub(a, b);
}

// CHECK-LABEL: @_Z9inc_ulong
// CHECK: cir.atomic.fetch(add, {{.*}} : !cir.ptr<!u64i>, {{.*}} : !u64i, seq_cst) fetch_first : !u64i

Expand All @@ -490,11 +541,30 @@ void inc_ulong(unsigned long* a, long b) {
unsigned long c = __sync_fetch_and_add(a, b);
}

// CHECK-LABEL: @_Z9sub_ulong
// CHECK: cir.atomic.fetch(sub, {{.*}} : !cir.ptr<!u64i>, {{.*}} : !u64i, seq_cst) fetch_first : !u64i

// LLVM-LABEL: @_Z9sub_ulong
// LLVM: atomicrmw sub ptr {{.*}}, i64 {{.*}} seq_cst, align 8
void sub_ulong(unsigned long* a, long b) {
unsigned long c = __sync_fetch_and_sub(a, b);
}


// CHECK-LABEL: @_Z9inc_uchar
// CHECK: cir.atomic.fetch(add, {{.*}} : !cir.ptr<!u8i>, {{.*}} : !u8i, seq_cst) fetch_first : !u8i

// LLVM-LABEL: @_Z9inc_uchar
// LLVM: atomicrmw add ptr {{.*}}, i8 {{.*}} seq_cst, align 1
void inc_uchar(unsigned char* a, char b) {
unsigned char c = __sync_fetch_and_add(a, b);
}
}

// CHECK-LABEL: @_Z9sub_uchar
// CHECK: cir.atomic.fetch(sub, {{.*}} : !cir.ptr<!u8i>, {{.*}} : !u8i, seq_cst) fetch_first : !u8i

// LLVM-LABEL: @_Z9sub_uchar
// LLVM: atomicrmw sub ptr {{.*}}, i8 {{.*}} seq_cst, align 1
void sub_uchar(unsigned char* a, char b) {
unsigned char c = __sync_fetch_and_sub(a, b);
}