[CIR][CIRGen][Builtin][Neon] Lower neon_vqaddq_v, neon_vqsubq and neon_vqsub #988
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Oct 17, 2024
| @@ -2304,29 +2304,35 @@ mlir::Value CIRGenFunction::buildCommonNeonBuiltinExpr( | |||
|
|
|||
| // This second switch is for the intrinsics that might have a more generic | |||
| // codegen solution so we can use the common codegen in future. | |||
| std::string intrincsName; | |||
There was a problem hiding this comment.
Why this isn't a StringRef?
There was a problem hiding this comment.
yes, should use StringRef
bcardosolopes
approved these changes
Oct 18, 2024
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
lanza
pushed a commit
that referenced
this pull request
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.