Skip to content

[llvm-lit] lit internal shell fail to execute parentheses syntax #102401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks done
Harini0924 opened this issue Aug 7, 2024 · 1 comment · Fixed by #105720 or #105729
Closed
3 tasks done

[llvm-lit] lit internal shell fail to execute parentheses syntax #102401

Harini0924 opened this issue Aug 7, 2024 · 1 comment · Fixed by #105720 or #105729
Assignees
@Harini0924
Labels
BOLT test-suite

Comments

@Harini0924
Copy link
Contributor

Harini0924 commented Aug 7, 2024 •
edited
Loading

lit’s internal shell cannot recognize and execute the () syntax, which is used in tests across BOLT and compiler-rt.

Error Displayed:

FAIL: BOLT :: X86/instrumentation-eh_frame_hdr.cpp (375 of 453)
******************** TEST 'BOLT :: X86/instrumentation-eh_frame_hdr.cpp' FAILED ********************
Exit Code: 127

Command Output (stdout):
--
# RUN: at line 9
(/usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf -SW /usr/local/google/home/harinidonthula/llvm-project/build/tools/bolt/test/X86/Output/instrumentation-eh_frame_hdr.cpp.tmp.instr | grep -v bolt; /usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf -lW /usr/local/google/home/harinidonthula/llvm-project/build/tools/bolt/test/X86/Output/instrumentation-eh_frame_hdr.cpp.tmp.instr |    grep LOAD | tail -n 1) | /usr/local/google/home/harinidonthula/llvm-project/build/bin/FileCheck /usr/local/google/home/harinidonthula/llvm-project/bolt/test/X86/instrumentation-eh_frame_hdr.cpp
# executed command: '(/usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf' -SW /usr/local/google/home/harinidonthula/llvm-project/build/tools/bolt/test/X86/Output/instrumentation-eh_frame_hdr.cpp.tmp.instr
# .---command stderr------------
# | '(/usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf': command not found
# `-----------------------------
# error: command failed with exit status: 127

--

********************

Files with failures in BOLT:

  • bolt/test/X86/end-symbol.test
  • bolt/test/X86/instrumentation-eh_frame_hdr.cpp

Files with failures in compiler-rt:

  • compiler-rt/test/ubsan/TestCases/TypeCheck/vptr.cpp
@Harini0924 Harini0924 changed the title [llvm-lit] lit internally shell to execute parentheses syntax [llvm-lit] lit internal shell fail to execute parentheses syntax Aug 7, 2024
@llvmbot
Copy link
Member

llvmbot commented Aug 7, 2024

@llvm/issue-subscribers-bolt

Author: None (Harini0924)

lit’s internal shell cannot recognize and execute the () syntax, which is used in tests across BOLT and compiler-rt.

Error Displayed:

FAIL: BOLT :: X86/instrumentation-eh_frame_hdr.cpp (375 of 453)
******************** TEST 'BOLT :: X86/instrumentation-eh_frame_hdr.cpp' FAILED ********************
Exit Code: 127

Command Output (stdout):
--
# RUN: at line 9
(/usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf -SW /usr/local/google/home/harinidonthula/llvm-project/build/tools/bolt/test/X86/Output/instrumentation-eh_frame_hdr.cpp.tmp.instr | grep -v bolt; /usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf -lW /usr/local/google/home/harinidonthula/llvm-project/build/tools/bolt/test/X86/Output/instrumentation-eh_frame_hdr.cpp.tmp.instr |    grep LOAD | tail -n 1) | /usr/local/google/home/harinidonthula/llvm-project/build/bin/FileCheck /usr/local/google/home/harinidonthula/llvm-project/bolt/test/X86/instrumentation-eh_frame_hdr.cpp
# executed command: '(/usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf' -SW /usr/local/google/home/harinidonthula/llvm-project/build/tools/bolt/test/X86/Output/instrumentation-eh_frame_hdr.cpp.tmp.instr
# .---command stderr------------
# | '(/usr/local/google/home/harinidonthula/llvm-project/build/bin/llvm-readelf': command not found
# `-----------------------------
# error: command failed with exit status: 127

--

********************

This was referenced Aug 9, 2024
Open
Open
Open
This was referenced Aug 22, 2024
Merged
Merged
Harini0924 added a commit that referenced this issue Aug 23, 2024
@Harini0924
[BOLT][test] Removed the use of parentheses in BOLT tests with lit in…
7f37932 
…ternal shell (#105720)

This patch addresses compatibility issues with the lit internal shell by
removing the use of subshell execution (parentheses and subshell syntax)
in the `BOLT` tests. The lit internal shell does not support
parentheses, so the tests have been refactored to use separate command
invocations, with outputs redirected to temporary files where necessary.

This change is relevant for enabling the lit internal shell by default,
as outlined in [[RFC] Enabling the Lit Internal Shell by
Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)

fixes: #102401
cjdb pushed a commit to cjdb/llvm-project that referenced this issue Aug 23, 2024
@Harini0924 @cjdb
[BOLT][test] Removed the use of parentheses in BOLT tests with lit in…
420b6f5 
…ternal shell (llvm#105720)

This patch addresses compatibility issues with the lit internal shell by
removing the use of subshell execution (parentheses and subshell syntax)
in the `BOLT` tests. The lit internal shell does not support
parentheses, so the tests have been refactored to use separate command
invocations, with outputs redirected to temporary files where necessary.

This change is relevant for enabling the lit internal shell by default,
as outlined in [[RFC] Enabling the Lit Internal Shell by
Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)

fixes: llvm#102401
@Harini0924 Harini0924 self-assigned this Aug 25, 2024
Harini0924 added a commit that referenced this issue Aug 27, 2024
@Harini0924
[compiler-rt][tests] Removed the use of parentheses in compiler-rt te…
d28c0fb 
…sts with lit internal shell (#105729)

This patch addresses compatibility issues with the lit internal shell by
removing the use of subshell execution (parentheses and subshell syntax)
in the `merge-posix.test` and `vptr.cpp` tests. The lit internal shell
does not support parentheses, so the tests have been refactored to use
separate command invocations.

This change is relevant for enabling the lit internal shell by default,
as outlined in [[RFC] Enabling the Lit Internal Shell by
Default](https://discourse.llvm.org/t/rfc-enabling-the-lit-internal-shell-by-default/80179)

fixes: #102401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Harini0924 Harini0924

Labels
BOLT test-suite
Projects
None yet
Milestone
No milestone
3 participants
@EugeneZelenko @llvmbot @Harini0924