Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DirectX] The dx.saturate intrinsic is not being scalarized #134378

Closed
bogner opened this issue Apr 4, 2025 · 0 comments · Fixed by #134381
Closed

[DirectX] The dx.saturate intrinsic is not being scalarized #134378

bogner opened this issue Apr 4, 2025 · 0 comments · Fixed by #134381
Assignees
@bogner
Labels
backend:DirectX

Comments

@bogner
Copy link
Contributor

bogner commented Apr 4, 2025

As seen in llvm-beanz/offload-test-suite#62, using HLSL's "saturate" operation on a vector is resulting in an error: Cannot create Saturate operation: Invalid overload type from the backend. This is because the intrinsic isn't being scalarized and there is no vector DXIL op when we try to lower.
bogner added a commit to bogner/llvm-project that referenced this issue Apr 4, 2025
@bogner
[DirectX] Scalarize the dx.saturate intrinsic
061f4c0 
The DXIL Saturate op only takes scalars.

Fixes llvm#134378.
@bogner bogner mentioned this issue Apr 4, 2025
Merged
@bogner bogner self-assigned this Apr 4, 2025
@bogner bogner moved this to Needs Review in HLSL Support Apr 4, 2025
bogner added a commit to bogner/llvm-project that referenced this issue Apr 7, 2025
@bogner
[DirectX] Scalarize the dx.saturate intrinsic
19bc612 
The DXIL Saturate op only takes scalars.

Fixes llvm#134378.
@bogner bogner closed this as completed in 0afa872 Apr 7, 2025
@github-project-automation github-project-automation bot moved this from Needs Review to Closed in HLSL Support Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogner bogner

Labels
backend:DirectX
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DirectX] Scalarize the dx.saturate intrinsic bogner/llvm-project
1 participant
@bogner