Skip to content

Support StackFrameFormat #137057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
JDevlieghere opened this issue Apr 23, 2025 · 2 comments · Fixed by #137113
Closed

Support StackFrameFormat #137057

JDevlieghere opened this issue Apr 23, 2025 · 2 comments · Fixed by #137113
Assignees
@JDevlieghere
Labels
lldb-dap

Comments

@JDevlieghere
Copy link
Member

The debug adapter protocol supports an option to provide formatting information for a stack frames as part of the StackTrace request. We should support this in lldb-dap.

https://microsoft.github.io/debug-adapter-protocol/specification#Types_StackFrameFormat
https://github.com/microsoft/VSDebugAdapterHost/wiki/Stack-Trace-and-Value-Formatting
@llvmbot
Copy link
Member

llvmbot commented Apr 23, 2025

@llvm/issue-subscribers-lldb-dap

Author: Jonas Devlieghere (JDevlieghere)

The debug adapter protocol supports an option to provide formatting information for a stack frames as part of the StackTrace request. We should support this in lldb-dap.

https://microsoft.github.io/debug-adapter-protocol/specification#Types_StackFrameFormat
https://github.com/microsoft/VSDebugAdapterHost/wiki/Stack-Trace-and-Value-Formatting

@JDevlieghere JDevlieghere self-assigned this Apr 23, 2025
@JDevlieghere
Copy link
Member Author

lldb-dap reports that it supports value and stack formatting (supportsValueFormattingOptions) but looking at the code, we support neither.

JDevlieghere added a commit to JDevlieghere/llvm-project that referenced this issue Apr 24, 2025
@JDevlieghere
[lldb-dap] Support StackFrameFormat
2168161 
The debug adapter protocol supports an option to provide formatting
information for a stack frames as part of the StackTrace request.
lldb-dap incorrectly advertises it supports this, but until this PR that
support wasn't actually implemented.

Fixes llvm#137057
@JDevlieghere JDevlieghere mentioned this issue Apr 24, 2025
Merged
JDevlieghere added a commit to swiftlang/llvm-project that referenced this issue Apr 28, 2025
@JDevlieghere
[lldb-dap] Support StackFrameFormat (llvm#137113)
98cee24 
The debug adapter protocol supports an option to provide formatting
information for a stack frames as part of the StackTrace request.
lldb-dap incorrectly advertises it supports this, but until this PR that
support wasn't actually implemented.

Fixes llvm#137057

Back-ported from commit 262158b
@JDevlieghere JDevlieghere mentioned this issue Apr 28, 2025
Merged
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this issue May 6, 2025
@JDevlieghere @IanWood1
[lldb-dap] Support StackFrameFormat (llvm#137113)
ffbe81d 
The debug adapter protocol supports an option to provide formatting
information for a stack frames as part of the StackTrace request.
lldb-dap incorrectly advertises it supports this, but until this PR that
support wasn't actually implemented.

Fixes llvm#137057
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this issue May 6, 2025
@JDevlieghere @IanWood1
[lldb-dap] Support StackFrameFormat (llvm#137113)
1eefa16 
The debug adapter protocol supports an option to provide formatting
information for a stack frames as part of the StackTrace request.
lldb-dap incorrectly advertises it supports this, but until this PR that
support wasn't actually implemented.

Fixes llvm#137057
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this issue May 6, 2025
@JDevlieghere @IanWood1
[lldb-dap] Support StackFrameFormat (llvm#137113)
f69d96d 
The debug adapter protocol supports an option to provide formatting
information for a stack frames as part of the StackTrace request.
lldb-dap incorrectly advertises it supports this, but until this PR that
support wasn't actually implemented.

Fixes llvm#137057
Ankur-0429 pushed a commit to Ankur-0429/llvm-project that referenced this issue May 9, 2025
@JDevlieghere @Ankur-0429
[lldb-dap] Support StackFrameFormat (llvm#137113)
41d3ae2 
The debug adapter protocol supports an option to provide formatting
information for a stack frames as part of the StackTrace request.
lldb-dap incorrectly advertises it supports this, but until this PR that
support wasn't actually implemented.

Fixes llvm#137057
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JDevlieghere JDevlieghere

Labels
lldb-dap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[lldb-dap] Support StackFrameFormat JDevlieghere/llvm-project
2 participants
@JDevlieghere @llvmbot