Skip to content

[libc++abi] lack of the detection of libunwind library files. #77843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ye-luo opened this issue Jan 11, 2024 · 0 comments · Fixed by #77991
Closed

[libc++abi] lack of the detection of libunwind library files. #77843

ye-luo opened this issue Jan 11, 2024 · 0 comments · Fixed by #77991
Assignees
@ldionne
Labels
cmake Build system in general and CMake in particular libc++abi libc++abi C++ Runtime Library. Not libc++.

Comments

@ye-luo
Copy link
Contributor

ye-luo commented Jan 11, 2024 •
edited
Loading

Triggered by #77687
libc++abi doesn't seem have strong enough dependency check/handling of libunwind.

cmake line

cmake -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++ -DCMAKE_BUILD_TYPE=Release -DGCC_INSTALL_PREFIX=$GCC_ROOT -DCMAKE_INSTALL_PREFIX=$INSTALL_FOLDER -DLLVM_ENABLE_BACKTRACES=ON -DLLVM_ENABLE_WERROR=OFF -DBUILD_SHARED_LIBS=OFF -DLLVM_ENABLE_RTTI=ON -DLLVM_ENABLE_ASSERTIONS=ON -DLLVM_ENABLE_PROJECTS="clang;compiler-rt;lld;openmp;flang;mlir" -DLLVM_ENABLE_RUNTIMES="libcxxabi;libcxx" -DOPENMP_ENABLE_LIBOMPTARGET=ON -DLIBOMPTARGET_ENABLE_DEBUG=ON ../llvm-project-nightly/llvm

My local build stops at

/usr/bin/ld: cannot find -lunwind_shared: No such file or directory
clang++: error: linker command failed with exit code 1 (use -v to see invocation)
make[5]: *** [libcxxabi/src/CMakeFiles/cxxabi_shared.dir/build.make:117: /gpfs/jlse-fs0/users/yeluo/opt/llvm-clang/build_mirror_offload_nightly/lib/x86_64-unknown-linux-gnu/libc++abi.so.1.0] Error 1

this kind of issue should be detected in the cmake stage of libcxxabi not at compile time.
@github-actions github-actions bot added libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. libc++abi libc++abi C++ Runtime Library. Not libc++. labels Jan 11, 2024
@ldionne ldionne self-assigned this Jan 12, 2024
@ldionne ldionne mentioned this issue Jan 12, 2024
Merged
ldionne added a commit that referenced this issue Jan 15, 2024
@ldionne
[libc++abi] Improve error message when libunwind is missing from LLVM…
48e5b5e 
…_ENABLE_RUNTIMES (#77991)

This doesn't actually prevent the build from failing, but it provides a
better diagnostic that explains what is needed in order to fix the build.

Fixes #77846
Fixes #77843
@EugeneZelenko EugeneZelenko added cmake Build system in general and CMake in particular and removed libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. labels Jan 15, 2024
searlmc1 pushed a commit to ROCm/llvm-project that referenced this issue Jan 16, 2024
@ldionne @ronlieb
[libc++abi] Improve error message when libunwind is missing from LLVM…
957be9f 
…_ENABLE_RUNTIMES (llvm#77991)

This doesn't actually prevent the build from failing, but it provides a
better diagnostic that explains what is needed in order to fix the build.

Fixes llvm#77846
Fixes llvm#77843

Change-Id: I4ad40d4c7ba2472ff75bf4c20cba1f9034507a75
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this issue Jan 28, 2024
@ldionne @justinfargnoli
[libc++abi] Improve error message when libunwind is missing from LLVM…
c0eb0a5 
…_ENABLE_RUNTIMES (llvm#77991)

This doesn't actually prevent the build from failing, but it provides a
better diagnostic that explains what is needed in order to fix the build.

Fixes llvm#77846
Fixes llvm#77843
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ldionne ldionne

Labels
cmake Build system in general and CMake in particular libc++abi libc++abi C++ Runtime Library. Not libc++.
Projects
None yet
Milestone
No milestone
3 participants
@ldionne @ye-luo @EugeneZelenko