-Wglobal-constructors false positive

[llvmbot]

Bugzilla Link	8095
Resolution	FIXED
Resolved on	Sep 18, 2010 00:26
Version	trunk
OS	Linux
Reporter	LLVM Bugzilla Contributor
CC	@DougGregor,@rjmccall

Extended Description

The following example gives a warning when -Wglobal-constructors is enabled:

struct Foo {
int x;
Foo(int x1) : x(x1) {}
};

void bar() {
static Foo a(0);
}

---

clang++ output:

a.cpp:8:13: warning: declaration requires a global constructor [-Wglobal-constructors]
static Foo a(0);
^~~

[lattner]

That does require a static constructor. When the optimizer is turned on, sometimes it can remove them, but it certainly does at -O0.

[lattner]

Ah, no, you're right, it's a static in a function, so it is lazily constructed.

[llvmbot]

Fixed in r113344.

[llvmbot]

When adding a "~Foo() {}" destructor I'm getting also a "global destructor" warning. Is it correct?

[rjmccall]

When adding a "~Foo() {}" destructor I'm getting also a "global destructor"
warning. Is it correct?

What platform are you on? On some platforms, those do require (conditionalized) global destructors.

[llvmbot]

x86_64 GNU/Linux

[rjmccall]

Apparently we don't actually pay attention to that. I've disabled the global-destructor warning on static locals for all targets (in r114269) and filed llvm/llvm-bugzilla-archive#8176 to track the target-specific fix.