Skip to content

[C23] Update status page for TS 18661 integration #105693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 23, 2024

Conversation

AaronBallman
Copy link
Collaborator

WG14 N2401 was removed from the list because it was library-only changes that don't impact the compiler.

Everything having to do with decimal floating-point types was changed to No because we do not currently have any support for those.

WG14 N2314 remains Unknown because it has changes to Annex F for binary floating-point types.

WG14 N2401 was removed from the list because it was library-only
changes that don't impact the compiler.

Everything having to do with decimal floating-point types was changed
to No because we do not currently have any support for those.

WG14 N2314 remains Unknown because it has changes to Annex F for binary
floating-point types.
@llvmbot llvmbot added the clang Clang issues not falling into any other category label Aug 22, 2024
@AaronBallman
Copy link
Collaborator Author

Up for review just to make sure there's not been work happening that I wasn't aware of, and to verify the removal of N2401.

Copy link
Contributor

@jcranmer-intel jcranmer-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to list most of these as "N/A" rather than "No", for the simple reason that decimal floating point is an optional feature we do not support. Or maybe just a footnote saying something to that effect?

</tr>
<tr>
<td><a href="https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2580.htm">N2580</a></td>
<td class="unknown" align="center">Unknown</td>
<td class="none" align="center">No</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N2580 looks to be an editorial change rather than a substantive change that can or cannot be conformed to.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, since this is under an omnibus feature category, I'll just remove this entry.

</tr>
<tr> <!-- Apr 2021 -->
<td><a href="https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2640.htm">N2640</a></td>
<td class="unknown" align="center">Unknown</td>
<td class="none" align="center">No</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to be vacuously yes: you need both Annex F conformance (which clang doesn't claim yet) and non-0 DEC_EVAL_METHOD (which I think @tahonermann et al aren't planning on) for this to matter.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks!

@AaronBallman
Copy link
Collaborator Author

It might be better to list most of these as "N/A" rather than "No", for the simple reason that decimal floating point is an optional feature we do not support. Or maybe just a footnote saying something to that effect?

I think eventually I'd like to split out optional annexes and TSes to a separate table so we can track whether they're available in Clang or not rather than whether we conform or not. But for right now, I'd say let's stick with No because it's clear that we don't support them rather than N/A which somewhat implies that we don't need to make compiler changes to support them.

N2580 is editorial and so it's removed entirely.
N2640 is vacuously supported.
@AaronBallman AaronBallman merged commit 3faf5b9 into llvm:main Aug 23, 2024
6 of 8 checks passed
@AaronBallman AaronBallman deleted the aballman-ts-18661-status branch August 23, 2024 15:17
cjdb pushed a commit to cjdb/llvm-project that referenced this pull request Aug 23, 2024
WG14 N2401 was removed from the list because it was library-only changes
that don't impact the compiler.

Everything having to do with decimal floating-point types was changed to
No because we do not currently have any support for those.

WG14 N2314 remains Unknown because it has changes to Annex F for binary
floating-point types.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c23 clang Clang issues not falling into any other category documentation website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants