-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[Policy] Replace "code owners" with "maintainers" #107384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
AaronBallman
merged 5 commits into
llvm:main
from
AaronBallman:aballman-maintainers-dev-policy
Sep 16, 2024
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
291c884
Replace "code owners" with "maintainers"
AaronBallman de7f064
Update based on review feedback
AaronBallman 10cadd5
Found another instance of "code owner" to replace
AaronBallman 38ee415
Fix minor nit based on review feedback
AaronBallman bc9ffc7
Updated based on review feedback
AaronBallman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -328,17 +328,17 @@ Release Patch Rules | |
Below are the rules regarding patching the release branch: | ||
|
||
#. Patches applied to the release branch may only be applied by the release | ||
manager, the official release testers or the code owners with approval from | ||
manager, the official release testers or the maintainers with approval from | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Unrelated side note: I think that nowadays only release managers can merge to release branches. |
||
the release manager. | ||
|
||
#. Release managers are encouraged, but not required, to get approval from code | ||
AaronBallman marked this conversation as resolved.
Show resolved
Hide resolved
|
||
owners before approving patches. If there is no code owner or the code owner | ||
is unreachable then release managers can ask approval from patch reviewers or | ||
other developers active in that area. | ||
owners before approving patches. If there are no reachable maintainers then | ||
release managers can ask approval from patch reviewers or other developers | ||
active in that area. | ||
|
||
#. *Before RC1* Patches should be limited to bug fixes, important optimization | ||
improvements, or completion of features that were started before the branch | ||
was created. As with all phases, release managers and code owners can reject | ||
was created. As with all phases, release managers and maintainers can reject | ||
patches that are deemed too invasive. | ||
|
||
#. *Before RC2* Patches should be limited to bug fixes or backend specific | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.