-
Notifications
You must be signed in to change notification settings - Fork 13.6k
[WebAssembly] Support assembly parsing for new EH #108668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
04640a3
[WebAssembly] Support assembly parsing for new EH
aheejin cbcf191
Add throw_ref to tests
aheejin 46bf1d7
Merge branch 'main' into eh_asmparser
aheejin dc379e7
test fix
aheejin 558f3a5
functype location
aheejin 9a0aaea
fix
aheejin 9b2f371
fix
aheejin 9d28b3f
Merge branch 'main' into eh_asmparser
aheejin d578e2c
eh-assembly-new.s -> eh-assembly.s
aheejin 17f3e92
Fix CalOpElem type
aheejin 29f7e2f
drive-by vix
aheejin a5cec4b
Error test cases
aheejin 69db6c2
Merge branch 'main' into eh_asmparser
aheejin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume
Dest
here is the branching depth of the targeted block. Does it have exactly the same meaning (in the context of the asm parser) as the BrList operands? If so, maybe it should have the same type?Actually the level of abstraction here seems slightly funny because the tag is represented as an
MCExpr*
(rather than a raw int) but the destination is a raw int. But I guess that makes sense in that MC explicitly models the tags as MCExprs but doesn't model basic blocks; and BrList already works this way.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made them
int64_t
just because the token's parser's return value wasint64_t
:llvm-project/llvm/include/llvm/MC/MCAsmMacro.h
Lines 115 to 118 in e99755d
And yeah I agree giving them the real type is better. Changed
Opcode
touint8_t
andDest
tounsigned
to reflect the real binary spec.