-
Notifications
You must be signed in to change notification settings - Fork 13.6k
Match .exe on Windows #128894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match .exe on Windows #128894
Conversation
If you have zlib (not standard) on Windows, this test runs, and it was missing a match for the file extension on lld.
@llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Chris B (llvm-beanz) ChangesIf you have zlib (not standard) on Windows, this test runs, and it was missing a match for the file extension on lld. Full diff: https://github.com/llvm/llvm-project/pull/128894.diff 1 Files Affected:
diff --git a/clang/test/Driver/hip-gz-options.hip b/clang/test/Driver/hip-gz-options.hip
index 7425d5fa847b3..bdef24e052ffb 100644
--- a/clang/test/Driver/hip-gz-options.hip
+++ b/clang/test/Driver/hip-gz-options.hip
@@ -9,6 +9,6 @@
// RUN: -ggdb -gz=zlib 2>&1 | FileCheck %s
// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
-// CHECK-DAG: {{".*lld" .* "--compress-debug-sections=zlib"}}
+// CHECK-DAG: {{".*lld.*" .* "--compress-debug-sections=zlib"}}
// CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
// CHECK: "--compress-debug-sections=zlib"
|
@llvm-beanz It looks like this test is failing on the ppc64le lld bot after your change: https://lab.llvm.org/buildbot/#/builders/168/builds/9117 Can you have a look? |
Maybe this fixes issues detected after llvm#128894
I posted another update to the test in #129611. I think that may address the problem, but I'm really unsure as I couldn't reproduce the specific failure. |
Maybe this fixes issues detected after #128894
That fixed it. Thank you! |
Maybe this fixes issues detected after llvm#128894
If you have zlib (not standard) on Windows, this test runs, and it was missing a match for the file extension on lld.