Skip to content

Match .exe on Windows #128894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Match .exe on Windows #128894

merged 1 commit into from
Feb 26, 2025

Conversation

llvm-beanz
Copy link
Collaborator

If you have zlib (not standard) on Windows, this test runs, and it was missing a match for the file extension on lld.

If you have zlib (not standard) on Windows, this test runs, and it was
missing a match for the file extension on lld.
@llvmbot llvmbot added clang Clang issues not falling into any other category clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' labels Feb 26, 2025
@llvmbot
Copy link
Member

llvmbot commented Feb 26, 2025

@llvm/pr-subscribers-clang-driver

@llvm/pr-subscribers-clang

Author: Chris B (llvm-beanz)

Changes

If you have zlib (not standard) on Windows, this test runs, and it was missing a match for the file extension on lld.


Full diff: https://github.com/llvm/llvm-project/pull/128894.diff

1 Files Affected:

  • (modified) clang/test/Driver/hip-gz-options.hip (+1-1)
diff --git a/clang/test/Driver/hip-gz-options.hip b/clang/test/Driver/hip-gz-options.hip
index 7425d5fa847b3..bdef24e052ffb 100644
--- a/clang/test/Driver/hip-gz-options.hip
+++ b/clang/test/Driver/hip-gz-options.hip
@@ -9,6 +9,6 @@
 // RUN:   -ggdb -gz=zlib 2>&1 | FileCheck %s
 
 // CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
-// CHECK-DAG: {{".*lld" .* "--compress-debug-sections=zlib"}}
+// CHECK-DAG: {{".*lld.*" .* "--compress-debug-sections=zlib"}}
 // CHECK-DAG: {{".*clang.*" .* "--compress-debug-sections=zlib"}}
 // CHECK: "--compress-debug-sections=zlib"

@llvm-beanz llvm-beanz merged commit 14da7d5 into llvm:main Feb 26, 2025
14 checks passed
@ZarkoT
Copy link
Contributor

ZarkoT commented Mar 3, 2025

@llvm-beanz It looks like this test is failing on the ppc64le lld bot after your change: https://lab.llvm.org/buildbot/#/builders/168/builds/9117

Can you have a look?

llvm-beanz added a commit to llvm-beanz/llvm-project that referenced this pull request Mar 3, 2025
Maybe this fixes issues detected after llvm#128894
@llvm-beanz
Copy link
Collaborator Author

@llvm-beanz It looks like this test is failing on the ppc64le lld bot after your change: https://lab.llvm.org/buildbot/#/builders/168/builds/9117

Can you have a look?

I posted another update to the test in #129611. I think that may address the problem, but I'm really unsure as I couldn't reproduce the specific failure.

llvm-beanz added a commit that referenced this pull request Mar 4, 2025
Maybe this fixes issues detected after #128894
@ZarkoT
Copy link
Contributor

ZarkoT commented Mar 4, 2025

That fixed it. Thank you!

jph-13 pushed a commit to jph-13/llvm-project that referenced this pull request Mar 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants