[TypeID] Update private typeid definition in DeferredLocInfo
#128968
Conversation
The parser's `DeferredLocInfo` uses an uncommon typeID setup, where it defines a private typeID for pointers to the struct. When using the fallback TypeID mechanism introduced in llvm#126999, the fallback type ID mechanism doesn't support anonymous namespaces, and the `INTERNAL_INLINE` mechanism doesn't support pointer types. Explicitly use `SELF_OWNING_TYPE_ID` for this case.
bethebunny
changed the title
DeferredLocInfo
|
@llvm/pr-subscribers-mlir Author: Stef Lindall (bethebunny) ChangesThe parser's When using the fallback TypeID mechanism introduced in #126999, the fallback type ID mechanism doesn't support anonymous namespaces, and the Explicitly use Full diff: https://github.com/llvm/llvm-project/pull/128968.diff 1 Files Affected:
diff --git a/mlir/lib/AsmParser/Parser.cpp b/mlir/lib/AsmParser/Parser.cpp
index c316f34d977e9..168231af9b410 100644
--- a/mlir/lib/AsmParser/Parser.cpp
+++ b/mlir/lib/AsmParser/Parser.cpp
@@ -839,8 +839,8 @@ class OperationParser : public Parser {
};
} // namespace
-MLIR_DECLARE_EXPLICIT_TYPE_ID(OperationParser::DeferredLocInfo *)
-MLIR_DEFINE_EXPLICIT_TYPE_ID(OperationParser::DeferredLocInfo *)
+MLIR_DECLARE_EXPLICIT_SELF_OWNING_TYPE_ID(OperationParser::DeferredLocInfo *)
+MLIR_DEFINE_EXPLICIT_SELF_OWNING_TYPE_ID(OperationParser::DeferredLocInfo *)
OperationParser::OperationParser(ParserState &state, ModuleOp topLevelOp)
: Parser(state), opBuilder(topLevelOp.getRegion()), topLevelOp(topLevelOp) {
|
|
@llvm/pr-subscribers-mlir-core Author: Stef Lindall (bethebunny) ChangesThe parser's When using the fallback TypeID mechanism introduced in #126999, the fallback type ID mechanism doesn't support anonymous namespaces, and the Explicitly use Full diff: https://github.com/llvm/llvm-project/pull/128968.diff 1 Files Affected:
diff --git a/mlir/lib/AsmParser/Parser.cpp b/mlir/lib/AsmParser/Parser.cpp
index c316f34d977e9..168231af9b410 100644
--- a/mlir/lib/AsmParser/Parser.cpp
+++ b/mlir/lib/AsmParser/Parser.cpp
@@ -839,8 +839,8 @@ class OperationParser : public Parser {
};
} // namespace
-MLIR_DECLARE_EXPLICIT_TYPE_ID(OperationParser::DeferredLocInfo *)
-MLIR_DEFINE_EXPLICIT_TYPE_ID(OperationParser::DeferredLocInfo *)
+MLIR_DECLARE_EXPLICIT_SELF_OWNING_TYPE_ID(OperationParser::DeferredLocInfo *)
+MLIR_DEFINE_EXPLICIT_SELF_OWNING_TYPE_ID(OperationParser::DeferredLocInfo *)
OperationParser::OperationParser(ParserState &state, ModuleOp topLevelOp)
: Parser(state), opBuilder(topLevelOp.getRegion()), topLevelOp(topLevelOp) {
|
The parser's
DeferredLocInfouses an uncommon TypeID setup, where it defines a private TypeID for pointers to the struct.When using the fallback TypeID mechanism introduced in #126999, the fallback TypeID mechanism doesn't support anonymous namespaces, and the
INTERNAL_INLINEmechanism doesn't support pointer types.Explicitly use
SELF_OWNING_TYPE_IDfor this case. This should always be safe for anonymous namespaces.