Skip to content

[libc++] Protect more code against -Wdeprecated. #130419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 9, 2025

Conversation

mordante
Copy link
Member

@mordante mordante commented Mar 8, 2025

This seems needed when updating the CI Docker image.

This seems needed when updating the CI Docker image.
@mordante mordante requested a review from a team as a code owner March 8, 2025 15:13
@llvmbot llvmbot added the libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi. label Mar 8, 2025
@llvmbot
Copy link
Member

llvmbot commented Mar 8, 2025

@llvm/pr-subscribers-libcxx

Author: Mark de Wever (mordante)

Changes

This seems needed when updating the CI Docker image.


Full diff: https://github.com/llvm/llvm-project/pull/130419.diff

1 Files Affected:

  • (modified) libcxx/include/__memory/allocator_traits.h (+1-1)
diff --git a/libcxx/include/__memory/allocator_traits.h b/libcxx/include/__memory/allocator_traits.h
index 2d9ab847e9f25..57b591e5b4b31 100644
--- a/libcxx/include/__memory/allocator_traits.h
+++ b/libcxx/include/__memory/allocator_traits.h
@@ -138,6 +138,7 @@ template <class _Alloc>
 using __propagate_on_container_swap _LIBCPP_NODEBUG =
     __detected_or_t<false_type, __propagate_on_container_swap_member, _Alloc>;
 
+_LIBCPP_SUPPRESS_DEPRECATED_PUSH
 // __is_always_equal
 template <class _Tp>
 using __is_always_equal_member _LIBCPP_NODEBUG = typename _Tp::is_always_equal;
@@ -147,7 +148,6 @@ using __is_always_equal _LIBCPP_NODEBUG =
     __detected_or_t<typename is_empty<_Alloc>::type, __is_always_equal_member, _Alloc>;
 
 // __allocator_traits_rebind
-_LIBCPP_SUPPRESS_DEPRECATED_PUSH
 template <class _Tp, class _Up, class = void>
 struct __has_rebind_other : false_type {};
 template <class _Tp, class _Up>

@mordante mordante merged commit fd973d2 into main Mar 9, 2025
85 checks passed
@mordante mordante deleted the users/mordante/protect_more_deprecated_code branch March 9, 2025 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
libc++ libc++ C++ Standard Library. Not GNU libstdc++. Not libc++abi.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants