Skip to content

[libc++] Make sure flat_set::key_compare handle boolean-testable correctly #132622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+45 −1
Open

[libc++] Make sure flat_set::key_compare handle boolean-testable correctly #132622

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cc53c54
Make sure compare handle boolean-testable correctly
hewillk Mar 23, 2025
7e1bdf8
added test
huixie90 May 18, 2025
18d8ab5
Merge branch 'llvm:main' into main-flat-set-compare
hewillk May 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libcxx/include/__flat_set/flat_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -602,7 +602,7 @@ class flat_set {

private:
_LIBCPP_HIDE_FROM_ABI bool __is_sorted_and_unique(auto&& __key_container) const {
auto __greater_or_equal_to = [this](const auto& __x, const auto& __y) { return !__compare_(__x, __y); };
auto __greater_or_equal_to = [this](const auto& __x, const auto& __y) -> bool { return !__compare_(__x, __y); };
return ranges::adjacent_find(__key_container, __greater_or_equal_to) == ranges::end(__key_container);
}

Expand Down