Skip to content

[libc] Update headers on aarch64 #133180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

michaelrj-google
Copy link
Contributor

The entrypoints for aarch64 are mostly up to date, but the headers are
not. This patch fixes that, and also makes explicit the dependency from
OSUtils/linux on sys/syscalls.h

The entrypoints for aarch64 are mostly up to date, but the headers are
not. This patch fixes that, and also makes explicit the dependency from
OSUtils/linux on sys/syscalls.h
@michaelrj-google michaelrj-google marked this pull request as ready for review March 26, 2025 23:32
@llvmbot llvmbot added the libc label Mar 26, 2025
@michaelrj-google
Copy link
Contributor Author

This patch should fix the issue here: #133180

@llvmbot
Copy link
Member

llvmbot commented Mar 26, 2025

@llvm/pr-subscribers-libc

Author: Michael Jones (michaelrj-google)

Changes

The entrypoints for aarch64 are mostly up to date, but the headers are
not. This patch fixes that, and also makes explicit the dependency from
OSUtils/linux on sys/syscalls.h


Full diff: https://github.com/llvm/llvm-project/pull/133180.diff

2 Files Affected:

  • (modified) libc/config/linux/aarch64/headers.txt (+22-5)
  • (modified) libc/src/__support/OSUtil/linux/CMakeLists.txt (+1)
diff --git a/libc/config/linux/aarch64/headers.txt b/libc/config/linux/aarch64/headers.txt
index f4223ed8a225d..01b0bf36498ce 100644
--- a/libc/config/linux/aarch64/headers.txt
+++ b/libc/config/linux/aarch64/headers.txt
@@ -1,43 +1,60 @@
 set(TARGET_PUBLIC_HEADERS
+    libc.include.arpa_inet
     libc.include.assert
     libc.include.complex
     libc.include.ctype
+    libc.include.dirent
     libc.include.dlfcn
     libc.include.elf
     libc.include.endian
     libc.include.errno
+    libc.include.fcntl
     libc.include.features
     libc.include.fenv
     libc.include.float
     libc.include.inttypes
     libc.include.limits
     libc.include.link
+    libc.include.locale
     libc.include.malloc
     libc.include.math
     libc.include.poll
     libc.include.pthread
+    libc.include.sched
     libc.include.search
+    libc.include.setjmp
     libc.include.signal
+    libc.include.spawn
     libc.include.stdbit
     libc.include.stdckdint
+    libc.include.stdfix
     libc.include.stdint
     libc.include.stdio
     libc.include.stdlib
     libc.include.string
     libc.include.strings
+    libc.include.sys_auxv
+    libc.include.sys_epoll
+    libc.include.sys_ioctl
     libc.include.sys_mman
+    libc.include.sys_prctl
+    libc.include.sys_queue
+    libc.include.sys_random
+    libc.include.sys_resource
+    libc.include.sys_select
     libc.include.sys_socket
+    libc.include.sys_stat
+    libc.include.sys_statvfs
     libc.include.sys_syscall
     libc.include.sys_time
-    libc.include.sysexits
+    libc.include.sys_types
+    libc.include.sys_utsname
     libc.include.sys_wait
+    libc.include.sysexits
+    libc.include.termios
     libc.include.threads
     libc.include.time
     libc.include.uchar
     libc.include.unistd
     libc.include.wchar
-
-    libc.include.sys_ioctl
-    # Disabled due to epoll_wait syscalls not being available on this platform.
-    # libc.include.sys_epoll
 )
diff --git a/libc/src/__support/OSUtil/linux/CMakeLists.txt b/libc/src/__support/OSUtil/linux/CMakeLists.txt
index 6c7014940407d..b9704d42cd33b 100644
--- a/libc/src/__support/OSUtil/linux/CMakeLists.txt
+++ b/libc/src/__support/OSUtil/linux/CMakeLists.txt
@@ -22,6 +22,7 @@ add_object_library(
     libc.hdr.types.struct_flock64
     libc.hdr.types.struct_f_owner_ex
     libc.hdr.types.off_t
+    libc.include.sys_syscall
 )
 
 add_header_library(

Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@michaelrj-google michaelrj-google merged commit 3a5d776 into llvm:main Mar 27, 2025
20 checks passed
@michaelrj-google michaelrj-google deleted the libcAarchHeaderFix branch March 27, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants