[ADT] Add DenseMap::insert_range

[vbvictor]

This PR add DenseMap::insert_range to DenseMap for consistency with existing DenseSet::insert_range, SmallSet::insert_range and std::map::insert_range.

[llvmbot]

@llvm/pr-subscribers-llvm-adt

Author: Baranov Victor (vbvictor)

Changes

This PR add DenseMap::insert_range to DenseMap for consistency with existing DenseSet::insert_range and SmallSet::insert_range.

---

Full diff: https://github.com/llvm/llvm-project/pull/133600.diff

2 Files Affected:

• (modified) llvm/include/llvm/ADT/DenseMap.h (+5)
• (modified) llvm/unittests/ADT/DenseMapTest.cpp (+11)

diff --git a/llvm/include/llvm/ADT/DenseMap.h b/llvm/include/llvm/ADT/DenseMap.h
index f0f992f8eac38..52834c8528eb0 100644
--- a/llvm/include/llvm/ADT/DenseMap.h
+++ b/llvm/include/llvm/ADT/DenseMap.h
@@ -14,6 +14,7 @@
 #ifndef LLVM_ADT_DENSEMAP_H
 #define LLVM_ADT_DENSEMAP_H
 
+#include "llvm/ADT/ADL.h"
 #include "llvm/ADT/DenseMapInfo.h"
 #include "llvm/ADT/EpochTracker.h"
 #include "llvm/Support/AlignOf.h"
@@ -302,6 +303,10 @@ class DenseMapBase : public DebugEpochBase {
       insert(*I);
   }
 
+  template <typename Range> void insert_range(Range &&R) {
+    insert(adl_begin(R), adl_end(R));
+  }
+
   template <typename V>
   std::pair<iterator, bool> insert_or_assign(const KeyT &Key, V &&Val) {
     auto Ret = try_emplace(Key, std::forward<V>(Val));
diff --git a/llvm/unittests/ADT/DenseMapTest.cpp b/llvm/unittests/ADT/DenseMapTest.cpp
index d1bbdde8dfc26..695ac99728a02 100644
--- a/llvm/unittests/ADT/DenseMapTest.cpp
+++ b/llvm/unittests/ADT/DenseMapTest.cpp
@@ -379,6 +379,17 @@ TEST(DenseMapCustomTest, EqualityComparison) {
   EXPECT_NE(M1, M3);
 }
 
+TEST(DenseMapCustomTest, InsertRange) {
+  DenseMap<int, int> M;
+
+  std::pair<int, int> InputVals[3] = {{0, 0}, {0, 1}, {1, 2}};
+  M.insert_range(InputVals);
+
+  EXPECT_EQ(2u, M.size());
+  EXPECT_THAT(M, testing::UnorderedElementsAre(testing::Pair(0, 0),
+                                               testing::Pair(1, 2)));
+}
+
 // Test for the default minimum size of a DenseMap
 TEST(DenseMapCustomTest, DefaultMinReservedSizeTest) {
   // IF THIS VALUE CHANGE, please update InitialSizeTest, InitFromIterator, and

[kuhar]

Can we also have a test for SmallDenseSet?

[vbvictor]

Added in llvm/unittests/ADT/DenseSetTest.cpp

[kuhar]

Sorry, I meant SmallDenseMap

[vbvictor]

Added SmallDenseMap, should I leave test for SmallDenseSet as is because it was absent in DenseSetTest.cpp?

[kuhar]

Thanks. I think it's fine either way.

[kazutakahirata]

@vbvictor I don't have any more comments beyond what @kuhar already mentioned, but I just want to say thanks for the PR!

[vbvictor]

If you are happy with the changes, you could merge the PR when all checks are passed.
I don't have write access.

[kuhar]

Thanks. I think it's fine either way.