Skip to content

[libc++] Removes the _LIBCPP_VERBOSE_ABORT_NOT_NOEXCEPT macro. #135494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions libcxx/docs/ReleaseNotes/21.rst
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,9 @@ Deprecations and Removals

- ``std::is_trivial`` and ``std::is_trivial_v`` are deprecated in C++26 and later.

- The ``_LIBCPP_VERBOSE_ABORT_NOT_NOEXCEPT`` has been removed, making ``std::__libcpp_verbose_abort``
unconditionally ``noexcept``.

Potentially breaking changes
----------------------------

Expand All @@ -91,9 +94,6 @@ LLVM 21
If you are using C++03 in your project, you should consider moving to a newer version of the Standard to get the most
out of libc++.

- The ``_LIBCPP_VERBOSE_ABORT_NOT_NOEXCEPT`` macro will be removed in LLVM 21, making ``std::__libcpp_verbose_abort``
unconditionally ``noexcept``.

- Non-conforming extension ``packaged_task::result_type`` will be removed in LLVM 21.

LLVM 22
Expand Down
8 changes: 1 addition & 7 deletions libcxx/include/__verbose_abort
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,10 @@

_LIBCPP_BEGIN_NAMESPACE_STD

#if defined(_LIBCPP_VERBOSE_ABORT_NOT_NOEXCEPT)
# define _LIBCPP_VERBOSE_ABORT_NOEXCEPT
#else
# define _LIBCPP_VERBOSE_ABORT_NOEXCEPT _NOEXCEPT
#endif

// This function should never be called directly from the code -- it should only be called through
// the _LIBCPP_VERBOSE_ABORT macro.
[[__noreturn__]] _LIBCPP_AVAILABILITY_VERBOSE_ABORT _LIBCPP_OVERRIDABLE_FUNC_VIS _LIBCPP_ATTRIBUTE_FORMAT(
__printf__, 1, 2) void __libcpp_verbose_abort(const char* __format, ...) _LIBCPP_VERBOSE_ABORT_NOEXCEPT;
__printf__, 1, 2) void __libcpp_verbose_abort(const char* __format, ...) _NOEXCEPT;

// _LIBCPP_VERBOSE_ABORT(format, args...)
//
Expand Down
2 changes: 1 addition & 1 deletion libcxx/src/verbose_abort.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ extern "C" void android_set_abort_message(const char* msg);

_LIBCPP_BEGIN_NAMESPACE_STD

_LIBCPP_WEAK void __libcpp_verbose_abort(char const* format, ...) _LIBCPP_VERBOSE_ABORT_NOEXCEPT {
_LIBCPP_WEAK void __libcpp_verbose_abort(char const* format, ...) noexcept {
// Write message to stderr. We do this before formatting into a
// buffer so that we still get some information out if that fails.
{
Expand Down
Loading